fix: API server should not attempt to read secrets in all namespaces (#…

…20950) * fix: api server is trying to list cluster wide secrets while generating apps Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Revert "fix: Fix argocd appset generate failure due to missing clusterrole (#20162)" This reverts commit fad534b. --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
argoproj · Nov 26, 2024 · 7f6340f · 7f6340f
1 parent 98688e0
commit 7f6340f
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 3 deletions.
diff --git a/cmd/argocd-server/commands/argocd_server.go b/cmd/argocd-server/commands/argocd_server.go
@@ -163,6 +163,7 @@ func NewCommand() *cobra.Command {
 			controllerClient, err := client.New(config, client.Options{Scheme: scheme})
 			errors.CheckError(err)
 			controllerClient = client.NewDryRunClient(controllerClient)
+			controllerClient = client.NewNamespacedClient(controllerClient, namespace)
 
 			// Load CA information to use for validating connections to the
 			// repository server, if strict TLS validation was requested.

diff --git a/manifests/cluster-rbac/server/argocd-server-clusterrole.yaml b/manifests/cluster-rbac/server/argocd-server-clusterrole.yaml
@@ -15,7 +15,6 @@ rules:
   - delete  # supports deletion a live object in UI
   - get     # supports viewing live object manifest in UI
   - patch   # supports `argocd app patch`
-  - list    # supports `argocd appset generate` with cluster generator
 - apiGroups:
   - ""
   resources:

diff --git a/manifests/ha/install.yaml b/manifests/ha/install.yaml
diff --git a/manifests/install.yaml b/manifests/install.yaml