fix: 20791 - sync multi-source application out of order source syncs (#…

…21071) Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
argoproj · Dec 5, 2024 · fa9023a · fa9023a
1 parent cdec7e2
commit fa9023a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/server/application/application.go b/server/application/application.go
@@ -2229,7 +2229,7 @@ func getAmbiguousRevision(app *appv1.Application, syncReq *application.Applicati
 	ambiguousRevision := ""
 	if app.Spec.HasMultipleSources() {
 		for i, pos := range syncReq.SourcePositions {
-			if pos == int64(sourceIndex) {
+			if pos == int64(sourceIndex+1) {
 				ambiguousRevision = syncReq.Revisions[i]
 			}
 		}

diff --git a/server/application/application_test.go b/server/application/application_test.go
@@ -2946,7 +2946,7 @@ func TestGetAmbiguousRevision_MultiSource(t *testing.T) {
 		},
 	}
 	syncReq := &application.ApplicationSyncRequest{
-		SourcePositions: []int64{0, 1},
+		SourcePositions: []int64{1, 2},
 		Revisions:       []string{"rev1", "rev2"},
 	}