Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Revisit new pod logs containers viewer introduced in v2.4 to get back to a fast single click #10166

Open
sharpyy opened this issue Aug 1, 2022 · 4 comments · Fixed by #11030
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@sharpyy
Copy link

sharpyy commented Aug 1, 2022

Summary

The new pod logs container viewer introduced in argo v2.4 via #8531 is slowing down operation work when wanting to reviewing quickly all the container logs of a pod. In the previous UI, it was taking a single click to view each container logs. WIth the new UI, it takes one click to go to the list of the containers and a second click to view the container logs. This is making troubleshooting not a efficient as before.

Motivation

The number of clicks required to view the container logs for a particular pods increased by 2 between v2.3 and v2.4. Reducing the number of clicks to a minimum is always best practice.

Proposal

We could probably improve this by replacing the first click to show up the list of containers by a UI rollover method.

@sharpyy sharpyy added the enhancement New feature or request label Aug 1, 2022
@crenshaw-dev crenshaw-dev added the component:ui User interfaces bugs and enhancements label Aug 1, 2022
@pookus
Copy link

pookus commented Aug 3, 2022

+1

@alexec
Copy link
Contributor

alexec commented Mar 9, 2023

Sorry. I closed this, but should not have done that.

@alexec
Copy link
Contributor

alexec commented Jun 16, 2023

fixed?

@jsoref
Copy link
Member

jsoref commented Jan 16, 2024

In some views, it's possible to see an aggregation from multiple sources, e.g. when looking at a deployment:
https://cd.apps.argoproj.io/applications/argo-cd?resource=kind%3APod%2Ckind%3ADeployment&node=apps%2FDeployment%2Fargocd%2Fargocd-repo-server%2F0&tab=logs
image

When looking at a pod that has more than one container, one can only see one container's logs at a time:
https://cd.apps.argoproj.io/applications/argo-cd?resource=kind%3APod&node=%2FPod%2Fargocd%2Fargocd-repo-server-568bcd4ff9-5twn6%2F0&tab=logs
image

For certain cases where a pod's containers talk to each other, it'd be really helpful to be able to see the logs from all containers at once.

I can imagine a case where one might only want to view a subset of containers (via a multi-select), so if someone wants to implement a feature where it's a multi-select instead of just an "all / " option, I'd definitely support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants