Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any application modifications only during the sync window #10301

Open
EugeneLugovtsov opened this issue Aug 12, 2022 · 2 comments
Open
Labels
enhancement New feature or request sync-windows Issues about the "sync windows" feature

Comments

@EugeneLugovtsov
Copy link

Summary

We use a deny sync window to be able to deploy applications to the prod environment only during the maintenance window. Everything works well, however, we found that the deny sync window does not block the delete operation. It turns out that it is possible to remove all apps from the prod environment accidentally. (we have already had a bug on the gitlab side + applicationset controller that removes everything from the prod env.)

Motivation

We can update/delete applications by mistake during deny sync window. That is why, I want to be sure that all application operations (sync, create, update, delete) will be performed only during allow sync window aka the maintenance window.

Proposal

Add the ability to set what application operations will be blocked during deny sync window. or just allow any application modifications only during allow sync window.

@EugeneLugovtsov EugeneLugovtsov added the enhancement New feature or request label Aug 12, 2022
@crenshaw-dev
Copy link
Member

I would add that override and maybe actions/* should be disable-able too.

How would you feel about a new field in the sync window description to list which actions should be blocked?

@crenshaw-dev crenshaw-dev added the GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day label Sep 14, 2022
@crenshaw-dev
Copy link
Member

Adding this as a potential Grace Hopper Celebration Open Source Day issue - but I'll note that this is a relatively challenging one. :-)

@crenshaw-dev crenshaw-dev added the sync-windows Issues about the "sync windows" feature label Sep 14, 2022
@crenshaw-dev crenshaw-dev removed the GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sync-windows Issues about the "sync windows" feature
Projects
None yet
Development

No branches or pull requests

2 participants