Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default deletion propagation policy for all apps #10834

Open
pjankovsky opened this issue Oct 6, 2022 · 2 comments
Open

Set default deletion propagation policy for all apps #10834

pjankovsky opened this issue Oct 6, 2022 · 2 comments
Labels
component:api API bugs and enhancements enhancement New feature or request

Comments

@pjankovsky
Copy link

Summary

I'd like to be able to set the default deletion propagation policy for all apps. Even better would be to set the default on a project or application level directly.

Motivation

Some services we deploy are critical enough that we would like to default deletion propagation policy to "non-cascading". When removing those services, we'd rather remove them from ArgoCD first, then perform cleanup via kubectl.

I could also see this being used by others to default to "background" if needed for a particular service.

There is also an ask to change the default behavior without a setting, but I think allowing a setting would be more flexible: #5724

Proposal

For a global setting, I think it could be a new key application.defaultDeletePolicy in the argocd-cm ConfigMap.
For project or application level, it could also be a new key defaultDeletePolicy in the individual spec.

@pjankovsky pjankovsky added the enhancement New feature or request label Oct 6, 2022
@jgwest jgwest added the component:api API bugs and enhancements label Oct 11, 2022
@Habulinec
Copy link

This would be a very-nice-to-have feature. Subscribed!

@BenCoughlan15
Copy link

could we get the option to set the PropagationPolicy policy?

I'm not so worried about foreground in dev, but in production this will kill live transactions for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api API bugs and enhancements enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants