Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-deletion resource hooks #13975

Open
adabuleanu opened this issue Jun 9, 2023 · 5 comments
Open

pre-deletion resource hooks #13975

adabuleanu opened this issue Jun 9, 2023 · 5 comments

Comments

@adabuleanu
Copy link

Summary

Please add support for pre/post delete hook.

Motivation

Current resource hooks do not support pre/post deletion hooks. Here is a [list with supported hooks compared to helm hooks|https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks]. There are many use cases where you want to run addtional actions before or after an ArgoCD Application is deleted.

Proposal

Functionality should be similar to what [helm provides for deletion hooks|https://helm.sh/docs/topics/charts_hooks/]

@adabuleanu adabuleanu added the enhancement New feature or request label Jun 9, 2023
@mrnvzch
Copy link

mrnvzch commented Oct 13, 2023

This might of interest, though I don't think you'll find a workaround there.

@eugenenelou
Copy link

The post-delete hook has been implemented.
It would be very useful to also have the pre-delete hook, to cleanup things outside of the application before deleting it.

@blakepettersson
Copy link
Member

Indeed, #16595 solved the PostDelete case

@ofirc
Copy link

ofirc commented Aug 2, 2024

Hi, are there any plans to support/implement that, or explain possible work-arounds for that?

@blakepettersson
Copy link
Member

blakepettersson commented Aug 2, 2024

@ofirc no current plans nor workarounds. I guess it wouldn't be too hard to implement pre-delete hooks, but someone has to do the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants