Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra otlp attrs for OpenTlemetry tracing #15070

Closed
penglongli opened this issue Aug 16, 2023 · 0 comments · Fixed by #15071
Closed

Add extra otlp attrs for OpenTlemetry tracing #15070

penglongli opened this issue Aug 16, 2023 · 0 comments · Fixed by #15071
Labels
enhancement New feature or request

Comments

@penglongli
Copy link
Contributor

Summary

ArgoCD now support OpenTlemetry with grpc by parameter otlp-address. But users cannot set extra attributes. We propose adding a param otlp-attrs to support it.

Because some users may have some requirements, such as: add token, carry cluster information, etc.

Motivation

Please give examples of your use case, e.g. when would you use this.

argocd-application-controller --otlp-address report-otlp.example.com --otlp-attrs "token:fake,cluster:test"

Proposal

With this proposal, need do:

  • Add command line execution parameters to input otlp attributes, such as otlp-attrs
  • Function trace.InitTracer() add otlpAttrs([]string) param support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant