Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document decoupling of ApplicationSet controller cmd parameters #15181

Open
so0k opened this issue Aug 23, 2023 · 2 comments
Open

Document decoupling of ApplicationSet controller cmd parameters #15181

so0k opened this issue Aug 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@so0k
Copy link

so0k commented Aug 23, 2023

Summary

Changes introduced in 2.8.0 by:

decoupled appilicationset.repo.server.plaintext configuration from controller.repo.server.plaintext. This may result in

transport: authentication handshake failed: tls: first record does not look like a TLS handshake

errors in the applicationSetController log after upgrading from 2.7 to 2.8.

Motivation

For some low-effort, in-cluster set ups without TLS an upgrade to 2.8 could break applicationset controller

Proposal

@crenshaw-dev
Copy link
Member

Thanks for the report! Do you have time for a PR?

@ashish-dua
Copy link

Any updates on PR and in which version of argocd Changes will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants