Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ApplicationSets in any namespace without setting allowed-scm-providers #15246

Closed
tculp opened this issue Aug 25, 2023 · 2 comments · Fixed by #15248
Closed

Allow ApplicationSets in any namespace without setting allowed-scm-providers #15246

tculp opened this issue Aug 25, 2023 · 2 comments · Fixed by #15248
Labels
enhancement New feature or request

Comments

@tculp
Copy link

tculp commented Aug 25, 2023

Summary

Currently, if you try to enable the "ApplicationSets in any namespace" feature, you must set the allowed-scm-providers config, otherwise you get an error. However, not setting that field should work and perhaps just print a warning that no scm providers are enabled.

I am using ArgoCD v2.8.1.

Motivation

I don't want any scm providers to be allowed, so I have to set the allowed-scm-providers field to a dummy URL. An empty string did not work.

Proposal

Default an unset allowed-scm-providers as assuming that no SCM providers are allowed.

@tculp tculp added the enhancement New feature or request label Aug 25, 2023
@crenshaw-dev
Copy link
Member

Instead of interpreting and empty --allowed-scm-providers to mean "allow none" (a breaking change), I recommend we introduce a new --disable-scm-generator flag to improve the UX.

@tculp
Copy link
Author

tculp commented Aug 25, 2023

That would work too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants