Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application deletion by applicationSet when using ApplicationSet Policy or syncPolicy.applicationsSync #15393

Open
flickers opened this issue Sep 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@flickers
Copy link
Contributor

flickers commented Sep 7, 2023

Summary

There is no way to see (in UI or in the argocd application CR) when an application generated from an applicationSet is no longer generated from said applicationSet when using applicationsSync create-update or create-only like is described in Managed Applications modification Policies.
Discussion on slack found there https://cloud-native.slack.com/archives/C01TSERG0KZ/p1692707246420029

Motivation

It is likely that this only applies when the applicationSet no longer generates an application. My use-case is that I would want to add an extra fail-safe to prevent deletion of applications even though we have branch protection in git to make sure that doesn't happen.
I would like to use syncPolicy.applicationsSync: create-update in applicationSets to prevent accidental deletion of applications in production clusters but would like ArgoCD to still show somehow the drift from desired state.

Proposal

For applications no longer generated from the applicationSets and you have syncPolicy.applicationsSync: create-update or syncPolicy.applicationsSync: create-only defined on the applicationSet level or if you have the controller parameters --policy create-update or --policy create-only set.
Produce some kind of status, label or any indicator (in the UI and in the argocd application CR) that the application is no longer being generated by the applicationSet generator.
Users of ArgoCD would then be able to fix the desired state (git in my case) if there was an accidental change/deletion or remove the application from cluster(s) if this application should indeed be deleted.

@flickers flickers added the enhancement New feature or request label Sep 7, 2023
@CaMoPeZzz
Copy link

I always face this problem when moving an application to another cluster (using Cluster generator). As a result, the application remains in the old cluster and does not differ in UI from the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants