ApplicationSets Across Namespaces Conflict

[reedjosh]

Checklist:

• [ ✅ ] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [ ✅ ] I've included steps to reproduce the bug.
• [ ✅ ] I've pasted the output of argocd version.

Describe the bug

An ApplicationSet that is project and namespace scoped can still conflict with an ApplicationSet in another namespace.

We are trying to implement namespace per tenant via the source and destination AppProject fields wherein our tenants can use apps and appsets in an isolated manner.

Unfortunately, we tried using appset-sync as the name of an ApplicationSet in two different namespaces, and that would continually conflict -- thus pruning what was created via the ApplciationSet in the other namespace.

From here the two sets of applications cycled their deployments.

Obviously this could be extremely dangerous to our production applications.

To Reproduce

Create two ApplicationSets in two different tenant namespaces with the same name.

Have these both target different namespaces.

The applications output will continually cycle in and out of existence as the output of one ApplicationSet will prune the output of the other.

Expected behavior

The namespacing of an ApplicationSet should work exactly like the namespacing of an Application.

someNamespace/someApp does not currently conflict with someOtherNamespace/someApp

yet,

someNamespace/someAppSet conflicts with someOtherNamespace/someAppSet

Screenshots

N/A

Version

argocd: v2.8.3+77556d9.dirty
  BuildDate: 2023-09-07T19:45:50Z
  GitCommit: 77556d9e64304c27c718bb0794676713628e435e
  GitTreeState: dirty
  GoVersion: go1.21.1
  Compiler: gc
  Platform: darwin/arm64
argocd-server: v2.8.4+c279299

Logs

N/A

[reedjosh]

#16207