[appset in any namespace] ApplicationSet with same name in different namespaces conflict

[speedfl]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

When creating two ApplicationSet with same name in two different source namespaces. The name conflict in the applicationset-controller and the source namespace for the application is not taken into account resulting in infinite loop deleting child applications and re-triggering reconcile loop. Logs attached

Quick fix: Ensure there are no name conflicting

To Reproduce

• Activate appset in any namespace
• Create two appset in different namespace with different behavior with same name

Expected behavior

Screenshots

Version

{
    "Version": "v2.8.4+c279299",
    "BuildDate": "2023-09-13T19:12:09Z",
    "GitCommit": "c27929928104dc37b937764baf65f38b78930e59",
    "GitTreeState": "clean",
    "GoVersion": "go1.20.6",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.1.0 2023-06-19T16:58:18Z",
    "HelmVersion": "v3.12.1+gf32a527",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.20.0"
}

Logs

time="2023-11-01T15:44:12Z" level=info msg="Deleted application" app=my-app-one appSet=my-application-set
time="2023-11-01T15:44:12Z" level=info msg="created Application" app=my-app-one appSet=my-application-set
time="2023-11-01T15:44:13Z" level=info msg="unchanged Application" app=my-app-one appSet=my-application-set

[speedfl]

Maybe a simple error in the applicationset conditions if conflict name are found could be a suitable solution.

Starting my investigation.

[speedfl]

After looking deeper it seems that createInCluster and deleteInCluster are not taking into account appset namespace:

• createInCluster:

  argo-cd/applicationset/controllers/applicationset_controller.go

  Line 719 in 51b4b20

  m[app.Name] = true

• deleteInCluster:

  argo-cd/applicationset/controllers/applicationset_controller.go

  Line 766 in 51b4b20

  m[app.Name] = true

Looking at the other impacts

[reedjosh]

#16114

[speedfl]

Looking at the code I don't think createOrUpdate will cause issues as it relies on ObjectKeyFromObject‎ which is using namespace and name.
I will write an integration test to validate the fix for createInCluster and deleteInCluster. Purpose of the fix is to use the objectKey for the maps

[speedfl]

I reproduced a sample usecase that can be run locally using make start-local.
Looking now at the fix.

https://github.com/speedfl/argocd-example-apps/tree/feature/appset-name-conflict/appset-name-conflict

[speedfl]

I tested a fix. I will push an MR soon

[speedfl]

The fix has been tested locally. Having some issues in writting e2e. Continuing my investigation

[speedfl]

I added an e2e test. It was not so easy to update the environment to support another external namespace.
I let reviewers take a look to it