Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostDelete hook aren't applied on existing applications #17193

Closed
3 tasks done
baurmatt opened this issue Feb 13, 2024 · 2 comments
Closed
3 tasks done

PostDelete hook aren't applied on existing applications #17193

baurmatt opened this issue Feb 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@baurmatt
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

When an existing application get's updated with a resource that contains argocd.argoproj.io/hook: PostDelete it doesn't get the post-delete-finalizer.argocd.argoproj.io/post-delete-finalizer.argocd.argoproj.io/cleanup finalizers required for the PostDeletion feature to work.

To Reproduce

  • Deploy a application without PostDelete hook
  • Update the source of the application to include a new resource having the PostDelete hook annotation
  • Sync the application
  • Delete the application
    ==> See how the PostDelete hook isn't triggered

Expected behavior

PostDelete hook is triggered.

Screenshots

Version

argocd: v2.10.0+2175939
  BuildDate: 2024-02-06T14:28:43Z
  GitCommit: 2175939ed6156ddd743e60f427f7f48118c971bf
  GitTreeState: clean
  GoVersion: go1.21.3
  Compiler: gc
  Platform: linux/amd64

Logs

Paste any relevant application logs here.
@baurmatt baurmatt added the bug Something isn't working label Feb 13, 2024
@baurmatt
Copy link
Author

Related to #16595

@baurmatt
Copy link
Author

Sync vs Refresh. My bad :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant