PostDelete hook not usable when deleting files used by generators

[hau21um]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

Using git generator in application set, which trigger application creation based on folder content with application configuration (helm in this case).

  generators:
  - git:
      files:
      - path: 'application-*/app-values.yaml'
      repoURL: https://github.com/hau21um/test-post-delete-app-set.git
      revision: HEAD

If this folder or some of its files needed to render the application manifest is deleted, application deletion is triggered properly, but the hook is not executed.

To Reproduce

• fork https://github.com/hau21um/test-post-delete-app-set
• modify all repoURL in test-post-delete-app-set.yaml to point to your fork
• apply the modified test-post-delete-app-set.yaml
• wait till all application-test-* are created and running
• delete in your forked repo the application-test-3 folder, or rename it to deleted-application-test-3 or remove/rename the app-values.yaml file
• wait till deletion is triggered and observe that no post-delete job is triggered, rather application ends with error message in app conditions "failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = helm template . --name-template application-test-3 --namespace application-test-3 --kube-version 1.26 --values <path to cached source>/application-test-3/app-values.yaml <api versions removed> --include-crds failed exit status 1: Error: open /application-test-3/app-values.yaml: no such file or directory"

To delete the application once all resources are removed from k8s by ArgoCD, you can remove finalizers section from Application metadata section, but this will not solve the main issue - that the post-delete is not run.

Expected behavior

The post-delete job should run and application get deleted.

Screenshots

Version

v2.11.0-rc3

Logs

failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = helm template . --name-template application-test-3 --namespace application-test-3 --kube-version 1.26 --values <path to cached source>/application-test-3/app-values.yaml <api versions removed> --include-crds failed exit status 1: Error: open /application-test-3/app-values.yaml: no such file or directory

[joebowbeer]

Related #16595 (adding context)

[cvaliente]

That explains a lot. Also hit by this bug.

[baldey-nz]

also hitting this bug, on v2.12.7+4d70c51

[GlenOsborneSpark]

also hitting this bug.. please fix

[mpluhar]

Same here, also hitting that bug.

[andycee]

Same here, but using the app of apps pattern. PostDelete hooks are not being executed after app deletion. Reproduced if I'll wait 10-15 min after app created

v2.13.1+af54ef8