Please allow disabling application spec in events

[michalrysavy-ext95730]

Summary

Hello all,

I found out this change - app spec in events and I believe it would be better to have this functionality switchable.

Please make a possibility to switch it off.

Motivation

We have two troubles with some application teams and if both problems concern the same application, this functionality will have significant impact to etcd size.

Problems are:

• some applications have huge spec in Application resource because of java truststores (for example) in values - in this case the values size is about 100-200kB
• some applications, especially in dev environments, have long-term issues in Application resource or in Helm chart which cause synchro loops and huge amount of events (thousands per an hour)

If one application had both problems at the same time, this functionality could actually cause 8000 events, each 200kB in size - in total 1.5GiB in etcd.

Proposal

It would be great to make a switch in argocd-cm ConfigMap.

[tooptoop4]

agree, really need #18205

[crenshaw-dev]

I think I'd be in favor of simply reverting the change to log the app spec and noting the removal in the upgrade notes. I think the additional logs have been less helpful for debugging than I'd hoped.

[jannfis]

I created #18458 for reverting the original PR.