Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.13.0-rc2] ArgoCD is not working when plugin without discovery is configured #20195

Closed
3 tasks done
pradithya opened this issue Oct 2, 2024 · 0 comments · Fixed by #20196
Closed
3 tasks done

[v2.13.0-rc2] ArgoCD is not working when plugin without discovery is configured #20195

pradithya opened this issue Oct 2, 2024 · 0 comments · Fixed by #20196
Labels
bug Something isn't working

Comments

@pradithya
Copy link
Contributor

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug
Many (if not all) applications registered in ArgoCD is incorrectly recognized as plugin application when a plugin without discovery functionality is configured.
The bug seems introduced by this PR #18053 . Specifically, this line of code in cmpSupports function.

To Reproduce

  1. Install ArgoCD version v2.13.0-rc1 / rc-2
  2. Create kustomize application, for example
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: bootstrap
  namespace: argocd
spec:
  project: default
  destination:
    name: in-cluster
    namespace: argocd
  source:
    repoURL: git@github.com:pradithya/argocd-hack.git
    targetRevision: main
    path: bootstrap
    kustomize: {}
  syncPolicy:
    automated: {}
    syncOptions:
    - ServerSideApply=true
  1. Create CM plugin without discovery functionality configured
  2. Check that the application above is somehow recognized as plugin app instead of kustomize app

Full repository to reproduce pradithya/argocd-hack@4ab374e

Expected behavior

application should be rendered properly and recognized as kustomize application instead of plugin application.

Screenshots
Screenshot 2024-10-02 at 5 41 14 PM

Screenshot 2024-10-02 at 5 38 28 PM

Version

2024/10/02 17:32:56 maxprocs: Leaving GOMAXPROCS=10: CPU quota undefined
argocd: v2.13.0-rc1+74a367d
  BuildDate: 2024-09-16T08:51:02Z
  GitCommit: 74a367d10e7110209610ba3ec225539ebe5f7522
  GitTreeState: clean
  GoVersion: go1.22.7
  Compiler: gc
  Platform: darwin/arm64
argocd-server: v2.13.0-rc2+0f083c9
  BuildDate: 2024-09-20T11:37:53Z
  GitCommit: 0f083c9e58638fc292cf064e294a1aa53caa5630
  GitTreeState: clean
  GoVersion: go1.23.1
  Compiler: gc
  Platform: linux/arm64
  Kustomize Version: v5.4.3 2024-07-19T16:40:33Z
  Helm Version: v3.15.2+g1a500d5
  Kubectl Version: v0.31.0
  Jsonnet Version: v0.20.0

Logs

Paste any relevant application logs here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant