Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appNamespace=undefined #20699

Closed
3 tasks
Hronom opened this issue Nov 8, 2024 · 8 comments · Fixed by #20819
Closed
3 tasks

appNamespace=undefined #20699

Hronom opened this issue Nov 8, 2024 · 8 comments · Fixed by #20819
Assignees
@andrii-korotkov-verkada
Labels
bug Something isn't working version:2.14 Latest confirmed affected version is 2.14

Comments

@Hronom
Copy link
Contributor

Hronom commented Nov 8, 2024 •
edited
Loading

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

After upgrading from 2.12.0 to 2.13.0 we found that resources show progress status when it's already healthy.
This means UI can't get actual status from Argo CD server.

If we hit button Refresh or Hard refresh - not helps.

If we do regular refresh of window in browser - only after this it helps to get actual state.

I see error in developer console of browser
image

For some reason it's doing calls to:

appNamespace=undefined

To Reproduce

Upgrade to 2.13.0 version

Expected behavior

No error

Screenshots

Version

Paste the output from `argocd version` here.

Logs

Paste any relevant application logs here.
@Hronom Hronom added the bug Something isn't working label Nov 8, 2024
@Hronom
Copy link
Contributor Author

Hronom commented Nov 8, 2024 •
edited
Loading

Found that version 2.12.0 doing calls to appNamespace=. But response is 200 there.

@tkukushkin
Copy link

tkukushkin commented Nov 8, 2024 •
edited
Loading

It seems it is connected with http path. If I open /applications/argocd/{name} with specifying application namespace, instead of /applications/{name} without namespace, it works.

@andrii-korotkov-verkada andrii-korotkov-verkada added the version:2.13 Latest confirmed affected version is 2.13 label Nov 11, 2024
@Hronom
Copy link
Contributor Author

Hronom commented Nov 11, 2024 •
edited
Loading

@andrii-korotkov-verkada please can you add someone to check, it actually blocks UI from getting actual state of app. So it may show it out of sync, but app already in healthy state.

More on this hit, refresh button in UI not helps.

Will be cool if fix can be included 2.13.1

@gustavo-maxmilhas
Copy link

Im getting the same problem, argocd v2.13.0

image

I think i figured out when it happens.
When i select the application through the text field (search text field) and click the application to go into it, the error happens.
If i click directly on the application box and go into it, the error doesnt happen.

It seems to be an issue with the application search text input.

Acessing from here will start the error:
image

@Hronom
Copy link
Contributor Author

Hronom commented Nov 18, 2024 •
edited
Loading

This is still a major issue for us that makes Argo CD of version 2.13.0 not usable, since search bar this is what we usually use. I believe for others too, then you have a lot of apps

@andrii-korotkov-verkada
Copy link
Contributor

I can reproduce on a build from a recent master. Interestingly, these 403 start appearing after the page is loaded and keep coming in continuously.

@andrii-korotkov-verkada
Copy link
Contributor

It might be this commit 3658f8e

andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 18, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
7f93899 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

It needs to be cherry-picked to v2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Merged
14 tasks
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 18, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
99c2819 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

It needs to be cherry-picked to v2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada andrii-korotkov-verkada added version:2.14 Latest confirmed affected version is 2.14 and removed version:2.13 Latest confirmed affected version is 2.13 labels Nov 18, 2024
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 18, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
bdfeea0 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada
Copy link
Contributor

I think I have a proper fix now, including better handling of undefined and also using a namespaced endpoint in a few more places if the app.metadata.namespace is available.

andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 18, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
163d59e 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 18, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
d9d7110 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 18, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
2c04134 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 19, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
99152d2 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 19, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
2619e38 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 19, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
4b7784a 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-cd that referenced this issue Nov 19, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
5bab9fa 
…20699)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
pasha-codefresh pushed a commit that referenced this issue Nov 20, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (#20699) (#…
3da5a3d 
…20819)

Fixes #20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Nov 20, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (#20699) (#…
0f8c80a 
…20819)

Fixes #20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Nov 20, 2024
Merged
pasha-codefresh pushed a commit that referenced this issue Nov 20, 2024
@gcp-cherry-pick-bot @andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (#20699) (#…
68606c6 
…20819) (#20860)

Fixes #20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Co-authored-by: Andrii Korotkov <137232734+andrii-korotkov-verkada@users.noreply.github.com>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this issue Nov 21, 2024
@andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
01fbe72 
…20699) (argoproj#20819)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this issue Dec 4, 2024
@andrii-korotkov-verkada @adriananeci
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
3380a80 
…20699) (argoproj#20819)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii-korotkov-verkada andrii-korotkov-verkada

Labels
bug Something isn't working version:2.14 Latest confirmed affected version is 2.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix repeated 403 due to app namespace being undefined (#20699) andrii-korotkov-verkada/argo-cd
4 participants
@Hronom @tkukushkin @gustavo-maxmilhas @andrii-korotkov-verkada