-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make App diff configMapGenerator aware #2397
Comments
I think we were planning to solve the exact same issue by #1636 . @jessesuen , can you please confirm if this is right? |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
👍 |
I'm not sure the suggestions above solve the initial issue/question which (in my understanding) is more about the visual diff in ArgoCD UI.
|
Would be nice to have something similar to how git detects renamed files when showing diff. |
Is your feature request related to a problem? Please describe.
We are using kustomize and
configMapGenerator
in a fair few places, including the automatic "hash suffix" feature.In Argo CD in the diff, it always shows this as a "removed file" and an "added file" instead of a diff.
I understand Argo CD literally shows the right stuff (because a brand new resource is being created).
For example, I have this in my
kustomization.yaml
:Whenever
config.yaml
changes, a resource likeaws-iam-authenticator-57k69g6486
is being deleted, and a new one likeaws-iam-authenticator-97t26c544m
is created.Describe the solution you'd like
It would be cool if it could somehow "understand" that this came from a
configMapGenerator
and show a nice side-by-side diff off the two resources (even though they have different names).Have you thought about contributing yourself?
Yes - mostly logging to get input from others and if a solution to this is even feasible.
The text was updated successfully, but these errors were encountered: