Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jsonnet Jpaths #2679

Closed
anarcher opened this issue Nov 9, 2019 · 2 comments
Closed

Support Jsonnet Jpaths #2679

anarcher opened this issue Nov 9, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@anarcher
Copy link

anarcher commented Nov 9, 2019

Summary

Support jsonnet jpaths(jsonnet -J) for argocd apps

Motivation

jsonnet supports jpaths . It can be useful with jsonnet based app. specially if we use it with jsonnet-bundler (https://github.com/jsonnet-bundler/jsonnet-bundler)

Proposal

spec:
  source:
    directory:
      jsonnet:
        jpaths:
        - ../../vendor
        - ../../lib
    path: baseapp/environments/default
    repoURL: https://github.com/anarcher/hello-tk.git
    targetRevision: HEAD
@anarcher anarcher added the enhancement New feature or request label Nov 9, 2019
@alexec
Copy link
Contributor

alexec commented Nov 12, 2019

@anarcher I've reviewed your PR and it looks a bit like the kind of problem people solve using custom plugins. Have you considered that please?

https://argoproj.github.io/argo-cd/operator-manual/custom_tools/

@anarcher
Copy link
Author

@alexec Thanks for the review. Generally, I agree that using custom tools for supporting jpaths is a good option. My thought was that jpaths is available option of Jsonnet so native support with Argocd makes sense. :-) But if you feel this issue is not necessary, I am ok to close this issue and PR :->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants