Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better protection against deleting argocd #7301

Open
3 tasks done
jsoref opened this issue Sep 27, 2021 · 1 comment
Open
3 tasks done

Provide better protection against deleting argocd #7301

jsoref opened this issue Sep 27, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jsoref
Copy link
Member

jsoref commented Sep 27, 2021

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

  1. Set up argocd
  2. create an application confusingly called applications
  3. Point it to a folder that includes the argocd application (so that argocd is managed as an application like everything else)
  4. Add other applications
  5. Enable show orphaned and check it
  6. Add other applications
  7. Wait ~18 months for a new dev to come along and decide "What is this Applications thing?" and choose to delete it.

Expected behavior

If an Application's ownership chain can be traced to owning the application that owns the running argocd, argocd should vehemently protest when asked to delete it.

Screenshots

I can draw a blank screen...

For simplicity, please accept this in lieu of a screenshot:
😭

Here's a picture of the Applications object looking confused at itself:
image

At the very least, it'd be nice if ArgoCD were able to recognize that this "unmanaged" object is in fact the object itself and not pretend it's some unknown object.

Version

I'm not entirely certain, ArgoCD deleted itself, so I don't have the version handy.

{
    "Version": "v2.1.0+50b0010",
    "BuildDate": "2021-08-04T00:28:17Z",
    "GitCommit": "50b00104704f28780b320ae043ecbda64214f132",
    "GitTreeState": "clean",
    "GoVersion": "go1.16.5",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KsonnetVersion": "v0.13.1",
    "KustomizeVersion": "v4.2.0 2021-06-30T22:49:26Z",
    "HelmVersion": "v3.6.0+g7f2df64",
    "KubectlVersion": "v0.21.0",
    "JsonnetVersion": "v0.17.0"
}

Logs

I can actually retrieve these if someone thinks ArgoCD did protest and they question my recreation of the steps.

Paste any relevant application logs here.
@jsoref jsoref added the bug Something isn't working label Sep 27, 2021
@shapirus
Copy link

It could really be solved if argocd supported a "deletion protection" flag, similar to the AWS EC2's instance "termination protection" flag that prevents any kind of deletion, be it automated or manual, until the flag is explicitly set to false in the object definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants