Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of API server dry-run in K8s v1.13 #804

Closed
jessesuen opened this issue Nov 18, 2018 · 4 comments
Closed

Make use of API server dry-run in K8s v1.13 #804

jessesuen opened this issue Nov 18, 2018 · 4 comments
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:tech-debt Enhancement invisible for the end user

Comments

@jessesuen
Copy link
Member

Today, we do a kubectl apply --dry-run of all resources, before performing the actual apply, in hopes of catching any manifest errors before deploying anything to the cluster. This is far from foolproof and the dry-run does not catch a lot of errors that only happen during the apply phase, which results in a partial successful deployment. An examples of these may be where a deployment's label selectors do not match the pod template labels.

There is a new API server feature (will be beta in v1.13) which will perform the validation server side, which will improve the experience by performing deeper checks on the user's manifests:

kubernetes/enhancements#576

To support this, we simply need to check if the cluster is running v1.13 and use the new --server-dry-run flag in place of --dry-run.

@jessesuen jessesuen added the enhancement New feature or request label Nov 18, 2018
@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 10, 2019
@alexmt alexmt removed the wontfix This will not be worked on label Apr 10, 2019
@stale
Copy link

stale bot commented Jun 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 9, 2019
@alexmt alexmt removed the wontfix This will not be worked on label Jun 9, 2019
@alexec alexec added the other label Jun 14, 2019
@stale
Copy link

stale bot commented Aug 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2019
@alexmt alexmt removed the wontfix This will not be worked on label Aug 19, 2019
@alexec alexec removed the other label Oct 10, 2019
@jannfis jannfis added component:core Syncing, diffing, cluster state cache type:tech-debt Enhancement invisible for the end user labels May 14, 2020
@leoluz
Copy link
Collaborator

leoluz commented Feb 2, 2023

Closing this in favor of #11574

@leoluz leoluz closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:tech-debt Enhancement invisible for the end user
Projects
None yet
Development

No branches or pull requests

5 participants