Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent volume claim are deleted automatically when deleting argocd app #9853

Open
anamaymane opened this issue Jul 1, 2022 · 5 comments
Labels
bug/priority:high Should be fixed in the next patch release bug Something isn't working component:ui User interfaces bugs and enhancements type:bug

Comments

@anamaymane
Copy link

When deleting an argocd app from the UI, PVC are deleted even if add the annotation argocd.argoproj.io/sync-options: Prune=false which prevents argocd from pruning the resource. Here is the yaml file of my persistent volume:

kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: elasticsearch-snapshot-pvc
  annotations:
    argocd.argoproj.io/sync-options: Prune=false
spec:
  accessModes:
    - "ReadWriteMany"
  resources:
    requests:
      storage: 1Gi
  storageClassName: nfs-rw

For the app deletion operation, I use the UI with the foreground delete option:
image

@anamaymane anamaymane added the bug Something isn't working label Jul 1, 2022
@anamaymane anamaymane changed the title Persistent volume claim are delete automatically when deleting argocd app Persistent volume claim are deleted automatically when deleting argocd app Jul 1, 2022
@aagu
Copy link

aagu commented Jul 1, 2022

We've encountered this issue few days ago.

@aagu
Copy link

aagu commented Jul 1, 2022

#7124

@chary1112004
Copy link

chary1112004 commented Feb 9, 2023

We faced same issue. pvc is deleted even already add below annotation:

metadata:
  annotations:
    argocd.argoproj.io/sync-options: Prune=false

@fanjlii
Copy link

fanjlii commented Dec 11, 2023

use argocd.argoproj.io/sync-options: Delete=false instead

@FredNass
Copy link

use argocd.argoproj.io/sync-options: Delete=false instead

Starting from ArgoCD v2.7

@alexmt alexmt added bug/priority:high Should be fixed in the next patch release component:ui User interfaces bugs and enhancements type:bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/priority:high Should be fixed in the next patch release bug Something isn't working component:ui User interfaces bugs and enhancements type:bug
Projects
None yet
Development

No branches or pull requests

6 participants