Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PKCE for web logins #9890

Closed
crenshaw-dev opened this issue Jul 6, 2022 · 4 comments · Fixed by #15889
Closed

Support PKCE for web logins #9890

crenshaw-dev opened this issue Jul 6, 2022 · 4 comments · Fixed by #15889
Assignees
@crenshaw-dev @mmerrill3
Labels
enhancement New feature or request security Security related
Milestone
v2.7

Comments

@crenshaw-dev
Copy link
Member

Summary

The CLI currently supports PKCE. The web interface should do so as well.

Proposal

I believe the API server will have to maintain a cache of code verifiers.
@crenshaw-dev crenshaw-dev added enhancement New feature or request security Security related labels Jul 6, 2022
@todaywasawesome
Copy link
Contributor

+1

@andrewkaczynski
Copy link

+1 :)

@crenshaw-dev crenshaw-dev added this to the v2.6 milestone Sep 14, 2022
@mmerrill3
Copy link
Contributor

mmerrill3 commented Nov 14, 2022 •
edited
Loading

@crenshaw-dev, this looks interesting, is anyone working on this yet?

@mmerrill3
Copy link
Contributor

@crenshaw-dev you can assign to me

mmerrill3 added a commit to mmerrill3/argo-cd that referenced this issue Nov 16, 2022
@mmerrill3
feature: pxce for UI argoproj#9890
52b2b17 
Signed-off-by: mmerrill3 <jjpaacks@gmail.com>
@mmerrill3 mmerrill3 mentioned this issue Nov 16, 2022
Closed
10 tasks
mmerrill3 added a commit to mmerrill3/argo-cd that referenced this issue Nov 19, 2022
@mmerrill3
feature: pkce for UI argoproj#9890
3f083bb 
Signed-off-by: mmerrill3 <jjpaacks@gmail.com>
@mmerrill3 mmerrill3 mentioned this issue Nov 19, 2022
Closed
10 tasks
@wtam2018 wtam2018 moved this to Backlog in Argo CD Roadmap Dec 12, 2022
@crenshaw-dev crenshaw-dev modified the milestones: v2.6, v2.7 Dec 12, 2022
@wtam2018 wtam2018 removed this from the v2.7 milestone Dec 12, 2022
@crenshaw-dev crenshaw-dev added this to the v2.7 milestone Dec 16, 2022
@Marvin9 Marvin9 mentioned this issue Oct 10, 2023
Merged
13 tasks
alexmt pushed a commit that referenced this issue Oct 30, 2023
@Marvin9
feat: PKCE authentication flow for web logins #9890 (#15889)
d747eb3 
feat: PKCE authentication flow for web logins #9890 (#15889)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this issue Nov 13, 2023
@Marvin9 @jmilic1
feat: PKCE authentication flow for web logins argoproj#9890 (argoproj…
9c5da3f 
…#15889)

feat: PKCE authentication flow for web logins argoproj#9890 (argoproj#15889)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this issue Dec 13, 2023
@Marvin9 @vladfr
feat: PKCE authentication flow for web logins argoproj#9890 (argoproj…
9733344 
…#15889)

feat: PKCE authentication flow for web logins argoproj#9890 (argoproj#15889)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
@Marvin9 @tesla59
feat: PKCE authentication flow for web logins argoproj#9890 (argoproj…
b2cdfd8 
…#15889)

feat: PKCE authentication flow for web logins argoproj#9890 (argoproj#15889)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
lyda pushed a commit to lyda/argo-cd that referenced this issue Mar 28, 2024
@Marvin9 @lyda
feat: PKCE authentication flow for web logins argoproj#9890 (argoproj…
724afd1 
…#15889)

feat: PKCE authentication flow for web logins argoproj#9890 (argoproj#15889)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this issue Jun 16, 2024
@Marvin9 @Hariharasuthan99
feat: PKCE authentication flow for web logins argoproj#9890 (argoproj…
7546c92 
…#15889)

feat: PKCE authentication flow for web logins argoproj#9890 (argoproj#15889)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@agaudreault agaudreault moved this from Backlog to Completed in Argo CD Roadmap Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crenshaw-dev crenshaw-dev

@mmerrill3 mmerrill3

Labels
enhancement New feature or request security Security related
Projects
Argo CD Roadmap
Status: Completed
Milestone
v2.7
5 participants
@crenshaw-dev @todaywasawesome @mmerrill3 @andrewkaczynski @wtam2018