fix(ui): User Info blob is too far to the right relative to Applications/Settings/Documentation #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiadong2022
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12016 +/- ##
=======================================
Coverage 49.55% 49.55%
=======================================
Files 269 269
Lines 47245 47245
=======================================
Hits 23413 23413
Misses 21532 21532
Partials 2300 2300 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shi, Stone <jiadong.shi@fmr.com>
shijiadong2022
force-pushed
the
fidelity-20230116-095214
branch
from
e9ce94e to
7ab64ce
Compare
|
@shijiadong2022 would you mind posting before/after screenshots? |
@crenshaw-dev can you take a look at the screenshots? Before |
|
Hi @crenshaw-dev, is this ready to be merged? Thanks! |
crenshaw-dev
changed the title
|
@shijiadong2022 would you mind rebasing? |
|
Thanks for having a look! |
|
Thanks @brianwarner and @crenshaw-dev. Rebased and merged now. |
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…ons/Settings/Documentation (argoproj#12016) Signed-off-by: Shi, Stone <jiadong.shi@fmr.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…ons/Settings/Documentation (argoproj#12016) Signed-off-by: Shi, Stone <jiadong.shi@fmr.com>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
…ons/Settings/Documentation (argoproj#12016) Signed-off-by: Shi, Stone <jiadong.shi@fmr.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…ons/Settings/Documentation (argoproj#12016) Signed-off-by: Shi, Stone <jiadong.shi@fmr.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…ons/Settings/Documentation (argoproj#12016) Signed-off-by: Shi, Stone <jiadong.shi@fmr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #11936