Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use background delete to match k8s terminology #15579

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Sep 19, 2023

In #15577 I ran into a problem where I couldn't figure out how the delete options ArgoCD presented related to the Kubernetes deletion strategies:
image

It's problematic to not use the same terms that the underlying system uses if the underlying system's documentation/behavior is something a user is likely to encounter. (If they're unlikely to ever encounter it, then introducing alternate terminology is fine, but that doesn't seem likely for ArgoCD & Kubernetes.)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: Josh Soref <jsoref@gmail.com>
@jsoref jsoref requested a review from a team as a code owner September 19, 2023 23:08
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7484f1d) 49.49% compared to head (bfabd54) 49.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15579   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files         270      270           
  Lines       47489    47489           
=======================================
  Hits        23506    23506           
  Misses      21672    21672           
  Partials     2311     2311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev added the component:ui User interfaces bugs and enhancements label Nov 14, 2023
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) December 5, 2023 18:35
@crenshaw-dev crenshaw-dev merged commit 5c51dcb into argoproj:master Dec 5, 2023
25 checks passed
@jsoref jsoref deleted the background-delete branch December 5, 2023 20:45
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
Signed-off-by: Josh Soref <jsoref@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Josh Soref <jsoref@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
Signed-off-by: Josh Soref <jsoref@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Josh Soref <jsoref@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Josh Soref <jsoref@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants