-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added identity-center.md doc for AWS SSO #15689
docs: added identity-center.md doc for AWS SSO #15689
Conversation
Signed-off-by: zeusal <zeusariaslucero@gmail.com>
7cd1a1d
to
b52b878
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15689 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.01%
==========================================
Files 269 269
Lines 46668 46668
==========================================
- Hits 23131 23128 -3
- Misses 21263 21265 +2
- Partials 2274 2275 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the PR @zeusal, some minor nits to fix
Hi @csantanapr @zeusal, ${user:AD_GUID} |
@csantanapr Thanks for the comments, I will apply them to my commit.
@ankursrc I know that the official documentation does not indicate that this attribute exists, but it does. If you have the possibility try it, I am currently using it for both Argocd and Jenkins. |
Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
@zeusal Can we mention that this is not officially supported in the AWS docs, however the workaround is currently working? |
@34fathombelow that sounds good, I can write it as a note. |
Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
@34fathombelow Suggestion added as a note. |
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last Nit
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
52754ad
to
83b4c47
Compare
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all your hard work and patience.
@34fathombelow Thank you so much for reviewing this PR 🙏 @zeusal get in touch with me on slack to work on getting the AWS docs updated in the mean time we can can have the note, when it's in the AWS docs we can come back remove it from argocd docs with another PR |
Thank you @morey-tech and @gdsoumya for reviewing this PR also 🙏 |
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@argocd-approvers-docs cannot approve #15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: added identity center doc (AWS SSO) Signed-off-by: zeusal <zeusariaslucero@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update docs/operator-manual/user-management/identity-center.md Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> --------- Signed-off-by: zeusal <zeusariaslucero@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: added identity center doc (AWS SSO) Signed-off-by: zeusal <zeusariaslucero@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update docs/operator-manual/user-management/identity-center.md Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> --------- Signed-off-by: zeusal <zeusariaslucero@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
* docs: added identity center doc (AWS SSO) Signed-off-by: zeusal <zeusariaslucero@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update docs/operator-manual/user-management/identity-center.md Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> --------- Signed-off-by: zeusal <zeusariaslucero@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: added identity center doc (AWS SSO) Signed-off-by: zeusal <zeusariaslucero@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update docs/operator-manual/user-management/identity-center.md Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> --------- Signed-off-by: zeusal <zeusariaslucero@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: added identity center doc (AWS SSO) Signed-off-by: zeusal <zeusariaslucero@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update docs/operator-manual/user-management/identity-center.md Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> --------- Signed-off-by: zeusal <zeusariaslucero@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
@zeusal Please how can i set this up? I have been trying to set it up but without any progress? |
Can you write your actual configuration and logs here? Please. |
below is my configuration
|
* docs: added identity center doc (AWS SSO) Signed-off-by: zeusal <zeusariaslucero@gmail.com> * Apply suggestions from code review Co-authored-by: Carlos Santana <csantana23@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Added note for attribute mapping Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update docs/operator-manual/user-management/identity-center.md Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Fixed image order and style doc Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> * Update identity-center.md Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> --------- Signed-off-by: zeusal <zeusariaslucero@gmail.com> Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com> Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com> Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not included in the `CODEOWNERS` file. This should be pretty benign to add. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Hello @geek0ps sorry for delay to answer. I think it's because you're adding ${aws_sso_group_id} without quotes, Can you try adding double quotes to this value? Regards! |
I have added specific documentation for configuring Argo CD with Identity Center (AWS SSO). #14703
Checklist:
This PR adds documentation to the User Management section to document integration of Identity Center SSO with ArgoCD as proposed in this discussion: #14703