Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added identity-center.md doc for AWS SSO #15689

Merged
merged 12 commits into from
Oct 27, 2023

Conversation

zeusal
Copy link
Contributor

@zeusal zeusal commented Sep 27, 2023

I have added specific documentation for configuring Argo CD with Identity Center (AWS SSO). #14703

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

This PR adds documentation to the User Management section to document integration of Identity Center SSO with ArgoCD as proposed in this discussion: #14703

@zeusal zeusal requested review from a team as code owners September 27, 2023 12:03
Signed-off-by: zeusal <zeusariaslucero@gmail.com>
@zeusal zeusal force-pushed the add-identity-center-doc branch from 7cd1a1d to b52b878 Compare September 27, 2023 12:07
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e2f2c9) 49.56% compared to head (b0b9412) 49.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15689      +/-   ##
==========================================
- Coverage   49.56%   49.55%   -0.01%     
==========================================
  Files         269      269              
  Lines       46668    46668              
==========================================
- Hits        23131    23128       -3     
- Misses      21263    21265       +2     
- Partials     2274     2275       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR @zeusal, some minor nits to fix

docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
@ankursrc
Copy link

Hi @csantanapr @zeusal,
I would like to highlight that official AWS Identity Center documentation does not mention user:groups attribute . This is not supported as of now. Only below attributes are supported for application integration.

${user:AD_GUID}
${user:email}
${user:familyName}
${user:givenName}
${user:middleName}
${user:name}
${user:preferredUsername}
${user:subject}

Link : https://docs.aws.amazon.com/singlesignon/latest/userguide/attributemappingsconcept.html#supportedssoattributes

@zeusal
Copy link
Contributor Author

zeusal commented Oct 20, 2023

thank you for the PR @zeusal, some minor nits to fix

@csantanapr Thanks for the comments, I will apply them to my commit.

Hi @csantanapr @zeusal, I would like to highlight that official AWS Identity Center documentation does not mention user:groups attribute . This is not supported as of now. Only below attributes are supported for application integration.

${user:AD_GUID} ${user:email} ${user:familyName} ${user:givenName} ${user:middleName} ${user:name} ${user:preferredUsername} ${user:subject}

Link : https://docs.aws.amazon.com/singlesignon/latest/userguide/attributemappingsconcept.html#supportedssoattributes

@ankursrc I know that the official documentation does not indicate that this attribute exists, but it does. If you have the possibility try it, I am currently using it for both Argocd and Jenkins.
https://repost.aws/questions/QUKn8D8aQUSTuxyjcEwfICow/is-it-possible-to-map-the-group-as-an-attribute

The proof that it works:
image
image

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
@zeusal zeusal requested a review from csantanapr October 20, 2023 06:10
@34fathombelow
Copy link
Member

thank you for the PR @zeusal, some minor nits to fix

@csantanapr Thanks for the comments, I will apply them to my commit.

Hi @csantanapr @zeusal, I would like to highlight that official AWS Identity Center documentation does not mention user:groups attribute . This is not supported as of now. Only below attributes are supported for application integration.
${user:AD_GUID} ${user:email} ${user:familyName} ${user:givenName} ${user:middleName} ${user:name} ${user:preferredUsername} ${user:subject}
Link : https://docs.aws.amazon.com/singlesignon/latest/userguide/attributemappingsconcept.html#supportedssoattributes

@ankursrc I know that the official documentation does not indicate that this attribute exists, but it does. If you have the possibility try it, I am currently using it for both Argocd and Jenkins. https://repost.aws/questions/QUKn8D8aQUSTuxyjcEwfICow/is-it-possible-to-map-the-group-as-an-attribute

The proof that it works: image image

@zeusal Can we mention that this is not officially supported in the AWS docs, however the workaround is currently working?

@zeusal
Copy link
Contributor Author

zeusal commented Oct 20, 2023

thank you for the PR @zeusal, some minor nits to fix

@csantanapr Thanks for the comments, I will apply them to my commit.

Hi @csantanapr @zeusal, I would like to highlight that official AWS Identity Center documentation does not mention user:groups attribute . This is not supported as of now. Only below attributes are supported for application integration.
${user:AD_GUID} ${user:email} ${user:familyName} ${user:givenName} ${user:middleName} ${user:name} ${user:preferredUsername} ${user:subject}
Link : https://docs.aws.amazon.com/singlesignon/latest/userguide/attributemappingsconcept.html#supportedssoattributes

@ankursrc I know that the official documentation does not indicate that this attribute exists, but it does. If you have the possibility try it, I am currently using it for both Argocd and Jenkins. https://repost.aws/questions/QUKn8D8aQUSTuxyjcEwfICow/is-it-possible-to-map-the-group-as-an-attribute
The proof that it works: image image

@zeusal Can we mention that this is not officially supported in the AWS docs, however the workaround is currently working?

@34fathombelow that sounds good, I can write it as a note.

Added note for attribute mapping 

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
@zeusal
Copy link
Contributor Author

zeusal commented Oct 24, 2023

@34fathombelow Suggestion added as a note.

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last Nit

docs/operator-manual/user-management/identity-center.md Outdated Show resolved Hide resolved
zeusal and others added 2 commits October 25, 2023 22:08
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
@zeusal zeusal requested a review from 34fathombelow October 25, 2023 20:15
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeusal zeusal requested a review from 34fathombelow October 26, 2023 17:51
@zeusal zeusal requested a review from 34fathombelow October 26, 2023 19:32
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
@zeusal zeusal force-pushed the add-identity-center-doc branch from 52754ad to 83b4c47 Compare October 27, 2023 07:02
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all your hard work and patience.

@csantanapr
Copy link
Member

csantanapr commented Oct 27, 2023

@34fathombelow Thank you so much for reviewing this PR 🙏

@zeusal get in touch with me on slack to work on getting the AWS docs updated in the mean time we can can have the note, when it's in the AWS docs we can come back remove it from argocd docs with another PR

@csantanapr
Copy link
Member

csantanapr commented Oct 27, 2023

Thank you @morey-tech and @gdsoumya for reviewing this PR also 🙏

@blakepettersson blakepettersson enabled auto-merge (squash) October 27, 2023 12:51
blakepettersson added a commit to blakepettersson/argo-cd that referenced this pull request Oct 27, 2023
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson merged commit b71277c into argoproj:master Oct 27, 2023
22 checks passed
crenshaw-dev pushed a commit that referenced this pull request Oct 27, 2023
@argocd-approvers-docs cannot approve #15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
* docs: added identity center doc (AWS SSO)

Signed-off-by: zeusal <zeusariaslucero@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Added note for attribute mapping 

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update docs/operator-manual/user-management/identity-center.md

Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

---------

Signed-off-by: zeusal <zeusariaslucero@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
* docs: added identity center doc (AWS SSO)

Signed-off-by: zeusal <zeusariaslucero@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Added note for attribute mapping

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update docs/operator-manual/user-management/identity-center.md

Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

---------

Signed-off-by: zeusal <zeusariaslucero@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* docs: added identity center doc (AWS SSO)

Signed-off-by: zeusal <zeusariaslucero@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Added note for attribute mapping 

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update docs/operator-manual/user-management/identity-center.md

Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

---------

Signed-off-by: zeusal <zeusariaslucero@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* docs: added identity center doc (AWS SSO)

Signed-off-by: zeusal <zeusariaslucero@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Added note for attribute mapping 

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update docs/operator-manual/user-management/identity-center.md

Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

---------

Signed-off-by: zeusal <zeusariaslucero@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
* docs: added identity center doc (AWS SSO)

Signed-off-by: zeusal <zeusariaslucero@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Added note for attribute mapping

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update docs/operator-manual/user-management/identity-center.md

Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

---------

Signed-off-by: zeusal <zeusariaslucero@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
@geek0ps
Copy link

geek0ps commented Apr 26, 2024

@zeusal Please how can i set this up? I have been trying to set it up but without any progress?

@zeusal
Copy link
Contributor Author

zeusal commented Apr 26, 2024

@zeusal Please how can i set this up? I have been trying to set it up but without any progress?

Can you write your actual configuration and logs here? Please.

@geek0ps
Copy link

geek0ps commented Apr 26, 2024

below is my configuration

configs:
  params:
    "server.insecure": true
  cm:
    create: true
    url: "https://${hostname}"
    exec.enabled: false
%{ if sso_enabled ~}
    dex.config: |
      logger:
        level: debug
        format: json
      connectors:
        - type: saml
          id: aws
          name: "AWS SSO"
          config:
            ssoURL: ${aws_sso_url}
            caData: ${aws_sso_cert}
            entityIssuer: https://${hostname}/api/dex/callback
            redirectURI: https://${hostname}/api/dex/callback
            usernameAttr: subject
            emailAttr: email
            groupsAttr: groups
%{ endif ~}
  rbac:
    create: true
    policy.default: 'role:readonly'
    policy.csv: |
      p, role:org-admin, applications, *, */*, allow
      p, role:org-admin, clusters, get, *, allow
      p, role:org-admin, repositories, get, *, allow
      p, role:org-admin, repositories, create, *, allow
      p, role:org-admin, repositories, update, *, allow
      p, role:org-admin, repositories, delete, *, allow
      p, role:org-admin, projects, get, *, allow
      p, role:org-admin, projects, create, *, allow
      p, role:org-admin, projects, update, *, allow
      p, role:org-admin, projects, delete, *, allow
      p, role:org-admin, logs, get, *, allow
      p, role:org-admin, exec, create, */*, allow
      g, ${aws_sso_group_id}, role:org-admin
    scopes: "[groups,email]"
    ```
    
    after doing this i get the following error:  bad input
    
    @zeusal 

@geek0ps
Copy link

geek0ps commented Apr 26, 2024

@zeusal Please how can i set this up? I have been trying to set it up but without any progress?

Can you write your actual configuration and logs here? Please.

can I write you an email ? @zeusal

Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* docs: added identity center doc (AWS SSO)

Signed-off-by: zeusal <zeusariaslucero@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Added note for attribute mapping 

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update docs/operator-manual/user-management/identity-center.md

Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Fixed image order and style doc

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

* Update identity-center.md

Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>

---------

Signed-off-by: zeusal <zeusariaslucero@gmail.com>
Signed-off-by: Zeus Arias Lucero <33123154+zeusal@users.noreply.github.com>
Co-authored-by: Zeus Arias <zeus.ariaslucero@ust.com>
Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@argocd-approvers-docs cannot approve argoproj#15689 since `mkdocs.yml` is not
included in the `CODEOWNERS` file. This should be pretty benign to add.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@zeusal
Copy link
Contributor Author

zeusal commented Jul 1, 2024

below is my configuration

configs:
  params:
    "server.insecure": true
  cm:
    create: true
    url: "https://${hostname}"
    exec.enabled: false
%{ if sso_enabled ~}
    dex.config: |
      logger:
        level: debug
        format: json
      connectors:
        - type: saml
          id: aws
          name: "AWS SSO"
          config:
            ssoURL: ${aws_sso_url}
            caData: ${aws_sso_cert}
            entityIssuer: https://${hostname}/api/dex/callback
            redirectURI: https://${hostname}/api/dex/callback
            usernameAttr: subject
            emailAttr: email
            groupsAttr: groups
%{ endif ~}
  rbac:
    create: true
    policy.default: 'role:readonly'
    policy.csv: |
      p, role:org-admin, applications, *, */*, allow
      p, role:org-admin, clusters, get, *, allow
      p, role:org-admin, repositories, get, *, allow
      p, role:org-admin, repositories, create, *, allow
      p, role:org-admin, repositories, update, *, allow
      p, role:org-admin, repositories, delete, *, allow
      p, role:org-admin, projects, get, *, allow
      p, role:org-admin, projects, create, *, allow
      p, role:org-admin, projects, update, *, allow
      p, role:org-admin, projects, delete, *, allow
      p, role:org-admin, logs, get, *, allow
      p, role:org-admin, exec, create, */*, allow
      g, ${aws_sso_group_id}, role:org-admin
    scopes: "[groups,email]"
    ```
    
    after doing this i get the following error:  bad input
    
    @zeusal 

Hello @geek0ps sorry for delay to answer.

I think it's because you're adding ${aws_sso_group_id} without quotes, Can you try adding double quotes to this value?

Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants