Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bounty): proposal for feature to hide annotations on secrets in UI #15699

Merged

Conversation

crenshaw-dev
Copy link
Member

I think this would be a good, small test case for the new feature-bounty system.

Per the bounty proposal rules we'll discuss this in the next maintainers' meeting.

…the UI

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8cd449) 49.55% compared to head (61aa74d) 49.87%.

❗ Current head 61aa74d differs from pull request most recent head 1406f72. Consider uploading reports for the commit 1406f72 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15699      +/-   ##
==========================================
+ Coverage   49.55%   49.87%   +0.32%     
==========================================
  Files         269      267       -2     
  Lines       46641    46166     -475     
==========================================
- Hits        23113    23026      -87     
+ Misses      21256    20881     -375     
+ Partials     2272     2259      -13     

see 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev marked this pull request as ready for review October 6, 2023 19:07
@crenshaw-dev crenshaw-dev requested review from a team as code owners October 6, 2023 19:07
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. It's been reviewed in the maintainer's meeting and alive for more than 7 days so I think we're good to merge and put out the bounty.

Bounty Rules

Signed-off-by: Dan Garfield <dan@codefresh.io>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 24, 2023 15:26
@todaywasawesome todaywasawesome added the Open Bounty This describes issues with a bounty. label Oct 24, 2023
@crenshaw-dev crenshaw-dev merged commit eab38b5 into argoproj:master Oct 24, 2023
25 of 26 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
…UI (argoproj#15699)

* docs(bounty): proposal for feature to hide annotations on secrets in the UI

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix file location

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
…UI (argoproj#15699)

* docs(bounty): proposal for feature to hide annotations on secrets in the UI

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix file location

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
…UI (argoproj#15699)

* docs(bounty): proposal for feature to hide annotations on secrets in the UI

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix file location

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…UI (argoproj#15699)

* docs(bounty): proposal for feature to hide annotations on secrets in the UI

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix file location

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…UI (argoproj#15699)

* docs(bounty): proposal for feature to hide annotations on secrets in the UI

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix file location

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open Bounty This describes issues with a bounty.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants