Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Allow notifications controller to notify on all namespaces #15702

Merged

updated examples/k8s-rbac/argocd-server-applications/kustomization.ya…

4de11d5
Select commit
Loading
Failed to load commit list.
Merged

fix(notifications): Allow notifications controller to notify on all namespaces #15702

updated examples/k8s-rbac/argocd-server-applications/kustomization.ya…
4de11d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2023 in 1s

49.91% (-0.01%) compared to 54601c8

View this Pull Request on Codecov

49.91% (-0.01%) compared to 54601c8

Details

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (54601c8) 49.92% compared to head (4de11d5) 49.91%.
Report is 113 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15702      +/-   ##
==========================================
- Coverage   49.92%   49.91%   -0.01%     
==========================================
  Files         263      266       +3     
  Lines       45223    46091     +868     
==========================================
+ Hits        22578    23007     +429     
- Misses      20427    20824     +397     
- Partials     2218     2260      +42     
Files Coverage Δ
notification_controller/controller/controller.go 60.74% <50.00%> (-4.78%) ⬇️

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.