Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Allow notifications controller to notify on all namespaces (cherry-pick 2.6) #15857

Merged
merged 2 commits into from
Oct 26, 2023

revert unnecessary changes

71a2cf2
Select commit
Loading
Failed to load commit list.
Merged

fix(notifications): Allow notifications controller to notify on all namespaces (cherry-pick 2.6) #15857

revert unnecessary changes
71a2cf2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2023 in 0s

48.40% (-0.15%) compared to 4bf8e7f

View this Pull Request on Codecov

48.40% (-0.15%) compared to 4bf8e7f

Details

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (4bf8e7f) 48.54% compared to head (71a2cf2) 48.40%.
Report is 2 commits behind head on release-2.6.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.6   #15857      +/-   ##
===============================================
- Coverage        48.54%   48.40%   -0.15%     
===============================================
  Files              247      248       +1     
  Lines            42134    42273     +139     
===============================================
+ Hits             20456    20462       +6     
- Misses           19609    19742     +133     
  Partials          2069     2069              
Files Coverage Δ
notification_controller/controller/controller.go 1.48% <7.69%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.