Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Argocd notification self service #15910

Closed
wants to merge 59 commits into from
Closed

feat: Argocd notification self service #15910

wants to merge 59 commits into from

Conversation

mayzhang2000
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@mayzhang2000
self service notification
dde06a6 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
95e6741 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
cb522d7 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
update notification engine
f7533c0 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000 mayzhang2000 requested review from a team as code owners October 11, 2023 17:15
@mayzhang2000 mayzhang2000 changed the title Argocd notification self service feat: Argocd notification self service Oct 11, 2023
@mayzhang2000
re-trigger build
1b1392f 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
self service notification
9522b21 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
25de483 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
88593e4 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
update notification engine
67bf721 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
re-trigger build
48e73f9 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
eba7382 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
82aae1e 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
7bc10b4 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
e68d9ad 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
15f9f5e 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (6e2f2c9) 49.56% compared to head (c7efef6) 49.56%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15910   +/-   ##
=======================================
  Coverage   49.56%   49.56%           
=======================================
  Files         269      269           
  Lines       46668    46709   +41     
=======================================
+ Hits        23131    23153   +22     
- Misses      21263    21280   +17     
- Partials     2274     2276    +2
Files Coverage Δ
server/server.go 56.23% <100.00%> (ø)
cmd/argocd/commands/admin/notifications.go 0.00% <0.00%> (ø)
notification_controller/controller/controller.go 67.28% <74.28%> (+5.14%) ⬆️
util/notification/settings/settings.go 30.95% <18.18%> (-12.53%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayzhang2000
update notification enginer version
734d440 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
Merge remote-tracking branch 'upstream/master' into may_notifications…
4212899 
…_self_service3
@mayzhang2000
update notification enginer version
81f6e16 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
9f87a0d 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000 mayzhang2000 requested a review from a team as a code owner October 12, 2023 18:23
@mayzhang2000
fixing go tidy
ada1a79 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
c1fa95e 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
a13dadd 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
Merge remote-tracking branch 'upstream/master' into may_notifications…
dd2575e 
…_self_service3
@mayzhang2000
fixing go tidy
3ab38fa 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
self service notification
1de42c7 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
261e176 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
93cfc1b 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
update notification engine
935ba57 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
re-trigger build
5731003 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
ed509de 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
self service notification
41dbbdb 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
d3a5399 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
revert back the changes for redis-ha
c3a1f74 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
update notification engine
b8a663a 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
re-trigger build
8eefe73 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
62917bf 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
0333cdc 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix conflict
587e692 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
update notification enginer version
1fe65d0 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
update notification enginer version
d651338 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
7e17055 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
32c83dc 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
59533c8 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
5dc6d05 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fixing go tidy
d396ba1 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
add back checkAppNotInAdditionalNamespaces
57e7b23 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
add cm and secret to clusterRole
c796241 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
if applicationNamespaces is not used, then use namespaced appClient
65c89ee 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
fix doc and test based on review
be5fbb1 
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
disable defining and using secrets within notification templates for …
84daba0 
…self-service

Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000
Merge remote-tracking branch 'origin/may_notifications_self_service3'…
fc7d787 
… into may_notifications_self_service3

# Conflicts:
#	docs/operator-manual/notifications/index.md
#	notification_controller/controller/controller.go
@mayzhang2000
Merge remote-tracking branch 'upstream/master' into may_notifications…
c7efef6 
…_self_service3
@mayzhang2000
Copy link
Contributor Author

This is replaced by #16488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mubarak-j mubarak-j mubarak-j left review comments

@crenshaw-dev crenshaw-dev crenshaw-dev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayzhang2000 @crenshaw-dev @mubarak-j