Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in declarative tests filename #15934

Merged

Conversation

ChristopherFry
Copy link
Contributor

This pull request fixes the typo in the declarative end-to-end tests filename, renaming test/e2e/delarative_test.go to test/e2e/declarative_test.go. Previously the filename was missing the c in declarative.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: Chris Fry <christopherfry@google.com>
@ChristopherFry ChristopherFry requested a review from a team as a code owner October 12, 2023 21:17
@crenshaw-dev crenshaw-dev merged commit ce12527 into argoproj:master Oct 28, 2023
26 checks passed
@ChristopherFry ChristopherFry deleted the cfry/declarative-tests-filename branch October 29, 2023 00:08
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
Signed-off-by: Chris Fry <christopherfry@google.com>
Signed-off-by: ymktmk <ymktmk.tt@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
Signed-off-by: Chris Fry <christopherfry@google.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
Signed-off-by: Chris Fry <christopherfry@google.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Chris Fry <christopherfry@google.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Chris Fry <christopherfry@google.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Chris Fry <christopherfry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants