-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added example of using build env vars in your Kustomized App #16025
Merged
blakepettersson
merged 1 commit into
argoproj:master
from
christianh814:docs/kustomize-build-env
Oct 19, 2023
Merged
docs: Added example of using build env vars in your Kustomized App #16025
blakepettersson
merged 1 commit into
argoproj:master
from
christianh814:docs/kustomize-build-env
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication Signed-off-by: Christian Hernandez <christian@chernand.io>
wanghong230
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16025 +/- ##
==========================================
- Coverage 49.62% 49.59% -0.03%
==========================================
Files 267 267
Lines 46479 46504 +25
==========================================
+ Hits 23063 23064 +1
- Misses 21144 21167 +23
- Partials 2272 2273 +1
☔ View full report in Codecov by Sentry. |
morey-tech
approved these changes
Oct 19, 2023
rbreeze
approved these changes
Oct 19, 2023
ymktmk
pushed a commit
to ymktmk/argo-cd
that referenced
this pull request
Oct 29, 2023
…ication (argoproj#16025) Signed-off-by: Christian Hernandez <christian@chernand.io>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
…ication (argoproj#16025) Signed-off-by: Christian Hernandez <christian@chernand.io> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…ication (argoproj#16025) Signed-off-by: Christian Hernandez <christian@chernand.io>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…ication (argoproj#16025) Signed-off-by: Christian Hernandez <christian@chernand.io>
6 tasks
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…ication (argoproj#16025) Signed-off-by: Christian Hernandez <christian@chernand.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16010
Added example of using build env vars in your Kustomized App, which should clear up some confusion.