Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added example of using build env vars in your Kustomized App #16025

Merged
merged 1 commit into from
Oct 19, 2023
Merged

docs: Added example of using build env vars in your Kustomized App #16025

merged 1 commit into from
Oct 19, 2023

Conversation

christianh814
Copy link
Member

Closes: #16010

Added example of using build env vars in your Kustomized App, which should clear up some confusion.

…ication

Signed-off-by: Christian Hernandez <christian@chernand.io>
@christianh814 christianh814 requested review from a team as code owners October 18, 2023 20:26
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (9e0e8d5) 49.62% compared to head (687b670) 49.59%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16025      +/-   ##
==========================================
- Coverage   49.62%   49.59%   -0.03%     
==========================================
  Files         267      267              
  Lines       46479    46504      +25     
==========================================
+ Hits        23063    23064       +1     
- Misses      21144    21167      +23     
- Partials     2272     2273       +1     
Files Coverage Δ
controller/appcontroller.go 54.01% <82.35%> (+0.04%) ⬆️
util/env/env.go 80.99% <0.00%> (-15.09%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson blakepettersson enabled auto-merge (squash) October 19, 2023 15:11
@blakepettersson blakepettersson merged commit bf80422 into argoproj:master Oct 19, 2023
22 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
…ication (argoproj#16025)

Signed-off-by: Christian Hernandez <christian@chernand.io>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
…ication (argoproj#16025)

Signed-off-by: Christian Hernandez <christian@chernand.io>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
…ication (argoproj#16025)

Signed-off-by: Christian Hernandez <christian@chernand.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…ication (argoproj#16025)

Signed-off-by: Christian Hernandez <christian@chernand.io>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…ication (argoproj#16025)

Signed-off-by: Christian Hernandez <christian@chernand.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example use of Build Environment variables in kustomization.yaml
6 participants