-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose notification secrets for request payload templating #16055
feat: expose notification secrets for request payload templating #16055
Conversation
fcd808e
to
a01c136
Compare
Within the related issue, @crenshaw-dev , pointed out that we should be careful to not log this sensitive data. I tried to find a case where this could happen and I didn't find any. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16055 +/- ##
==========================================
+ Coverage 49.55% 49.59% +0.04%
==========================================
Files 269 269
Lines 46595 46642 +47
==========================================
+ Hits 23091 23134 +43
- Misses 21232 21235 +3
- Partials 2272 2273 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
0133a65
to
5236341
Compare
…oproj#16055) Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
…oproj#16055) Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
…oproj#16055) Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
…oproj#16055) Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
…oproj#16055) Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
Closes #10724
Checklist: