Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose notification secrets for request payload templating #16055

Merged

Conversation

eroznik
Copy link
Contributor

@eroznik eroznik commented Oct 20, 2023

Closes #10724

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@eroznik eroznik requested a review from a team as a code owner October 20, 2023 16:54
@eroznik eroznik force-pushed the issue-10724-notification-secrets branch from fcd808e to a01c136 Compare October 20, 2023 16:55
@eroznik eroznik requested a review from a team as a code owner October 20, 2023 16:55
@eroznik
Copy link
Contributor Author

eroznik commented Oct 20, 2023

Within the related issue, @crenshaw-dev , pointed out that we should be careful to not log this sensitive data. I tried to find a case where this could happen and I didn't find any.
When the notification succeeds, there are no logs with "body". When the notification fails, we get a log with body, but it contains the "template" without the resolved values.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (973565e) 49.55% compared to head (5236341) 49.59%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16055      +/-   ##
==========================================
+ Coverage   49.55%   49.59%   +0.04%     
==========================================
  Files         269      269              
  Lines       46595    46642      +47     
==========================================
+ Hits        23091    23134      +43     
- Misses      21232    21235       +3     
- Partials     2272     2273       +1     
Files Coverage Δ
util/notification/settings/settings.go 43.47% <100.00%> (+43.47%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
@eroznik eroznik force-pushed the issue-10724-notification-secrets branch 2 times, most recently from 0133a65 to 5236341 Compare October 25, 2023 08:34
@crenshaw-dev crenshaw-dev merged commit bc5fb81 into argoproj:master Oct 25, 2023
40 of 41 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
…oproj#16055)

Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
…oproj#16055)

Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
…oproj#16055)

Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…oproj#16055)

Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…oproj#16055)

Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make secrets available for notification templates
2 participants