docs: ApplicationSets generators docs to use go templates (#16109) #16127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16127 +/- ##
=======================================
Coverage 49.56% 49.56%
=======================================
Files 269 269
Lines 46668 46668
=======================================
Hits 23131 23131
Misses 21263 21263
Partials 2274 2274 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
…lates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
KunalSin9h
force-pushed
the
gotemplate
branch
from
c8b3042 to
fd6510a
Compare
crenshaw-dev
changed the title
Comment on lines
-142
to
-146
| - id: infra | ||
| - name: infra | ||
| project: infra-project | ||
| - id: team-two | ||
| - name: team-two | ||
| project: team-two-project | ||
| template: |
There was a problem hiding this comment.
Good catches on the spacing/naming issues!
ymktmk
pushed a commit
to ymktmk/argo-cd
that referenced
this pull request
Oct 29, 2023
…goproj#16109) (argoproj#16127) * docs: migrating fasttemplate to go-template; Git Generator Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: missing yaml language specifier stopping syntax highlighting Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate List Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate Matrix, Merge & SCM Provider Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrating fasttemplate to go-template Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> --------- Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> Signed-off-by: ymktmk <ymktmk.tt@gmail.com>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
…goproj#16109) (argoproj#16127) * docs: migrating fasttemplate to go-template; Git Generator Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: missing yaml language specifier stopping syntax highlighting Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate List Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate Matrix, Merge & SCM Provider Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrating fasttemplate to go-template Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> --------- Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…goproj#16109) (argoproj#16127) * docs: migrating fasttemplate to go-template; Git Generator Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: missing yaml language specifier stopping syntax highlighting Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate List Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate Matrix, Merge & SCM Provider Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrating fasttemplate to go-template Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> --------- Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…goproj#16109) (argoproj#16127) * docs: migrating fasttemplate to go-template; Git Generator Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: missing yaml language specifier stopping syntax highlighting Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate List Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate Matrix, Merge & SCM Provider Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrating fasttemplate to go-template Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> --------- Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…goproj#16109) (argoproj#16127) * docs: migrating fasttemplate to go-template; Git Generator Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: missing yaml language specifier stopping syntax highlighting Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate List Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate Matrix, Merge & SCM Provider Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrating fasttemplate to go-template Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> --------- Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
joebowbeer
reviewed
Jun 11, 2024
| @@ -122,6 +124,8 @@ kind: ApplicationSet | |||
| metadata: | |||
| name: cluster-git | |||
| spec: | |||
| goTemplate: true | |||
There was a problem hiding this comment.
@KunalSin9h Does this work?
Line 134 says:
Note that this would not work with goTemplate enabled,
nested merge keys are not supported there.
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…goproj#16109) (argoproj#16127) * docs: migrating fasttemplate to go-template; Git Generator Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: missing yaml language specifier stopping syntax highlighting Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate List Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrate Matrix, Merge & SCM Provider Generators page to go-templates Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> * docs: migrating fasttemplate to go-template Signed-off-by: Kunal Singh <kunalsin9h@gmail.com> --------- Signed-off-by: Kunal Singh <kunalsin9h@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Fixes: #16109
This issue require lots of minors and major documentation update, so i am going to do this is small chunks so that it will be possible to get all details and do code review.
About the issue: As it is decided to remove support for fasttemplate with Go Template in ArgoCD v3.0.0, this pr update the documentation to use Go templates.
I am kicking it off by updating Git Generator page first. then after approval i will move froward.
Todo: