Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Include ClusterRole manifests in cluster-wide installation #16153

Conversation

motoki317
Copy link

@motoki317 motoki317 commented Oct 30, 2023

Fixes #16022 (along with #16057)
Related: argoproj/argo-helm#2315

I have added a ClusterRole and a ClusterRoleBinding manifests to the cluster-wide installation manifests, and regenerated install.yaml and ha/install.yaml with make manifests.

This PR also includes:

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@motoki317 motoki317 requested review from a team as code owners October 30, 2023 12:46
… in cluster-wide installation

Signed-off-by: motoki317 <motoki317@gmail.com>
…on controller's implementation

Signed-off-by: motoki317 <motoki317@gmail.com>
@motoki317 motoki317 force-pushed the fix/notifications-controller-permission branch from 962cb20 to 8a22105 Compare October 30, 2023 12:53
…nt notifications-controller

Signed-off-by: motoki317 <motoki317@gmail.com>
@motoki317 motoki317 force-pushed the fix/notifications-controller-permission branch from 8a22105 to e5dec6e Compare October 31, 2023 00:27
@motoki317
Copy link
Author

I commented in #16022 (comment), but now I'm not sure if we need this PR or not.
Adapt Kubernetes RBAC part in documentation already states that users need to apply extra manifests in examples/k8s-rbac/argocd-server-applications if they want to use Applications in any namespace.
But I think this part of documentation is easy to miss. Maybe we can make the extra manifests part of the default installation manifests, like I did in this change?

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (48f175b) 49.56% compared to head (e5dec6e) 49.55%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16153      +/-   ##
==========================================
- Coverage   49.56%   49.55%   -0.02%     
==========================================
  Files         269      269              
  Lines       46827    46891      +64     
==========================================
+ Hits        23212    23236      +24     
- Misses      21339    21374      +35     
- Partials     2276     2281       +5     
Files Coverage Δ
notification_controller/controller/controller.go 62.93% <50.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motoki317
Copy link
Author

Maybe we can make the extra manifests part of the default installation manifests, like I did in this change?

@crenshaw-dev @mayzhang2000 It would be awesome if you had opinions to my comment above, or to whether we need this PR at all or not.
Thanks!

@motoki317
Copy link
Author

Closing this PR as the cluster roles should still be an opt-in: #16022 (comment)

@motoki317 motoki317 closed this Nov 1, 2023
@motoki317 motoki317 deleted the fix/notifications-controller-permission branch November 1, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD Notifications Controller - Permission issue
1 participant