-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notifications): Include ClusterRole manifests in cluster-wide installation #16153
fix(notifications): Include ClusterRole manifests in cluster-wide installation #16153
Conversation
… in cluster-wide installation Signed-off-by: motoki317 <motoki317@gmail.com>
…on controller's implementation Signed-off-by: motoki317 <motoki317@gmail.com>
962cb20
to
8a22105
Compare
…nt notifications-controller Signed-off-by: motoki317 <motoki317@gmail.com>
8a22105
to
e5dec6e
Compare
I commented in #16022 (comment), but now I'm not sure if we need this PR or not. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16153 +/- ##
==========================================
- Coverage 49.56% 49.55% -0.02%
==========================================
Files 269 269
Lines 46827 46891 +64
==========================================
+ Hits 23212 23236 +24
- Misses 21339 21374 +35
- Partials 2276 2281 +5
☔ View full report in Codecov by Sentry. |
@crenshaw-dev @mayzhang2000 It would be awesome if you had opinions to my comment above, or to whether we need this PR at all or not. |
Closing this PR as the cluster roles should still be an opt-in: #16022 (comment) |
Fixes #16022 (along with #16057)
Related: argoproj/argo-helm#2315
I have added a ClusterRole and a ClusterRoleBinding manifests to the cluster-wide installation manifests, and regenerated
install.yaml
andha/install.yaml
withmake manifests
.This PR also includes:
Checklist: