Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Ensure consistent proper case of Kubernetes #16205

Merged
merged 3 commits into from
Nov 1, 2023
Merged

docs: Ensure consistent proper case of Kubernetes #16205

merged 3 commits into from
Nov 1, 2023

Conversation

adamdmharvey
Copy link
Contributor

@adamdmharvey adamdmharvey commented Nov 1, 2023 •
edited
Loading

Minor touch up 🧹 to ensure "Kubernetes" is properly cased in the documentation. Also found a minor typo (build vs. built) in the contributing docs.

Love the docs; thought I'd start contributing. 😁

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@adamdmharvey
docs: Consistent proper case of Kubernetes
047c72a 
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
@adamdmharvey
docs: Fix minor typo
a1bb6b4 
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
@adamdmharvey adamdmharvey requested review from a team as code owners November 1, 2023 16:07
blakepettersson
blakepettersson approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (26264b8) 49.55% compared to head (48ee84a) 49.54%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16205      +/-   ##
==========================================
- Coverage   49.55%   49.54%   -0.01%     
==========================================
  Files         269      269              
  Lines       46891    46892       +1     
==========================================
- Hits        23236    23234       -2     
- Misses      21374    21376       +2     
- Partials     2281     2282       +1
Files Coverage Δ
server/server.go 56.18% <100.00%> (-0.05%) ⬇️
cmd/argocd/commands/project.go 0.00% <0.00%> (ø)
server/applicationset/applicationset.go 59.91% <90.90%> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

Love the docs; thought I'd start contributing. 😁

❤️ thanks!

@crenshaw-dev
Copy link
Member

I see a build failure. You can fix it by running make clidocsgen.

@adamdmharvey
fix: Proper case Kubernetes
48ee84a 
Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
@adamdmharvey
Copy link
Contributor Author

Thanks @crenshaw-dev ; clean now!

@blakepettersson blakepettersson enabled auto-merge (squash) November 1, 2023 21:35
jannfis
jannfis approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you a bunch!

@blakepettersson blakepettersson merged commit 8d6c092 into argoproj:master Nov 1, 2023
25 checks passed
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@adamdmharvey @jmilic1
docs: Ensure consistent proper case of Kubernetes (argoproj#16205)
ecf8db1 
* docs: Consistent proper case of Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* docs: Fix minor typo

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* fix: Proper case Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

---------

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@adamdmharvey @vladfr
docs: Ensure consistent proper case of Kubernetes (argoproj#16205)
731e3c1 
* docs: Consistent proper case of Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* docs: Fix minor typo

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* fix: Proper case Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

---------

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@adamdmharvey @tesla59
docs: Ensure consistent proper case of Kubernetes (argoproj#16205)
6826054 
* docs: Consistent proper case of Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* docs: Fix minor typo

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* fix: Proper case Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

---------

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@adamdmharvey @lyda
docs: Ensure consistent proper case of Kubernetes (argoproj#16205)
d85f0e0 
* docs: Consistent proper case of Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* docs: Fix minor typo

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* fix: Proper case Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

---------

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@adamdmharvey @Hariharasuthan99
docs: Ensure consistent proper case of Kubernetes (argoproj#16205)
61f4453 
* docs: Consistent proper case of Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* docs: Fix minor typo

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

* fix: Proper case Kubernetes

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>

---------

Signed-off-by: Adam Harvey <33203301+adamdmharvey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamdmharvey @crenshaw-dev @blakepettersson @jannfis