chore: fix superagent vulnerability #16305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
zhaque44
force-pushed
the
fix-superagent-vulnerability
branch
from
bc1a211 to
231dc29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16305 +/- ##
==========================================
+ Coverage 49.50% 49.52% +0.01%
==========================================
Files 269 269
Lines 47011 47011
==========================================
+ Hits 23274 23280 +6
+ Misses 21453 21447 -6
Partials 2284 2284 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Nov 14, 2023
|
Not cherry-picking since it's not a high/critical vuln. |
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: zhaque44 <haque.zubair@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the npm superagent vulnerability:
https://argo-cd.readthedocs.io/en/stable/snyk/master/argocd-test.html
updated superagent and semver, the real underlying comes from:
semver npm library we need to update that to version 7.5.2 or higher
Checklist: