Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): remove extra space in application tree pod group view (#14797) #16358

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix(ui): remove extra space in application tree pod group view (#14797) #16358

merged 1 commit into from
Nov 30, 2023

Conversation

ashinsabu3
Copy link
Contributor

@ashinsabu3 ashinsabu3 commented Nov 16, 2023 •
edited
Loading

Fix extra space in application tree pod group
fixes: #14797

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@ashinsabu3
Fix extra space in application tree pod group
581ef19 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
@ashinsabu3 ashinsabu3 requested a review from a team as a code owner November 16, 2023 13:08
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ede1a8) 49.55% compared to head (581ef19) 49.55%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16358   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       47039    47039           
=======================================
  Hits        23310    23310           
  Misses      21443    21443           
  Partials     2286     2286

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev changed the title fix: remove extra space in application tree pod group view fix(ui): remove extra space in application tree pod group view (#14797) Nov 16, 2023
ashutosh16
ashutosh16 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashinsabu3
Copy link
Contributor Author

Bumping for review @crenshaw-dev

ishitasequeira
ishitasequeira approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit 673d661 into argoproj:master Nov 30, 2023
30 checks passed
irinam0992 pushed a commit to irinam0992/argo-cd that referenced this pull request Nov 30, 2023
@ashinsabu3 @irinam0992
Fix extra space in application tree pod group (argoproj#16358)
7625e7f 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
Signed-off-by: irinam0992 <irinam0992@gmail.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@ashinsabu3 @vladfr
Fix extra space in application tree pod group (argoproj#16358)
f202fca 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@ashinsabu3 @tesla59
Fix extra space in application tree pod group (argoproj#16358)
1a9de49 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@ashinsabu3
Fix extra space in application tree pod group (argoproj#16358)
6705e83 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@ashinsabu3 @lyda
Fix extra space in application tree pod group (argoproj#16358)
8f13595 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@ashinsabu3 @Hariharasuthan99
Fix extra space in application tree pod group (argoproj#16358)
303fafb 
Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@ashutosh16 ashutosh16 ashutosh16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pod group rows are visible even if no pods are in the group
3 participants
@ashinsabu3 @ashutosh16 @ishitasequeira