Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PostDelete hook support #16595

Merged
merged 3 commits into from
Dec 18, 2023

Address code review comments

230db9b
Select commit
Loading
Failed to load commit list.
Merged

feat: PostDelete hook support #16595

Address code review comments
230db9b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2023 in 1s

49.51% (+0.00%) compared to a761a49

View this Pull Request on Codecov

49.51% (+0.00%) compared to a761a49

Details

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (a761a49) 49.50% compared to head (230db9b) 49.51%.
Report is 12 commits behind head on master.

Files Patch % Lines
controller/appcontroller.go 43.82% 43 Missing and 7 partials ⚠️
controller/hook.go 58.87% 29 Missing and 15 partials ⚠️
pkg/apis/application/v1alpha1/types.go 0.00% 6 Missing ⚠️
controller/state.go 70.00% 2 Missing and 1 partial ⚠️
controller/sync.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #16595    +/-   ##
========================================
  Coverage   49.50%   49.51%            
========================================
  Files         270      271     +1     
  Lines       47488    47659   +171     
========================================
+ Hits        23508    23597    +89     
- Misses      21670    21731    +61     
- Partials     2310     2331    +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov