Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix indentation for preserve file mode #16598

Merged
merged 1 commit into from
Dec 14, 2023
Merged

docs: fix indentation for preserve file mode #16598

merged 1 commit into from
Dec 14, 2023

Conversation

yedayak
Copy link
Contributor

@yedayak yedayak commented Dec 13, 2023 •
edited
Loading

The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Checklist:

  • (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue. - not relevant
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them. - not relevant
  • Does this PR require documentation updates? - Only docs changes here
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged. - not relevant
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@yedayak yedayak requested review from a team as code owners December 13, 2023 16:36
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d70f9a4) 49.49% compared to head (2b4b37e) 49.49%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16598   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files         270      270           
  Lines       47488    47488           
=======================================
  Hits        23506    23506           
  Misses      21671    21671           
  Partials     2311     2311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yedayak
docs: fix indentation for preserve file mode
2b4b37e 
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Signed-off-by: yedayak <yedaya.ka@gmail.com>
@yedayak yedayak force-pushed the preserve-perms-docs branch from 79ae46d to 2b4b37e Compare December 13, 2023 16:56
ishitasequeira
ishitasequeira approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yedayak !! LGTM!!

@ishitasequeira ishitasequeira merged commit ecef174 into argoproj:master Dec 14, 2023
30 checks passed
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@yedayak @tesla59
docs: fix indentation for preserve file mode (argoproj#16598)
e87635d 
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Signed-off-by: yedayak <yedaya.ka@gmail.com>
@yedayak yedayak deleted the preserve-perms-docs branch January 15, 2024 14:28
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@yedayak
docs: fix indentation for preserve file mode (argoproj#16598)
1001f85 
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Signed-off-by: yedayak <yedaya.ka@gmail.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@yedayak @lyda
docs: fix indentation for preserve file mode (argoproj#16598)
7ae9652 
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Signed-off-by: yedayak <yedaya.ka@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@yedayak @Hariharasuthan99
docs: fix indentation for preserve file mode (argoproj#16598)
cebb09f 
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Signed-off-by: yedayak <yedaya.ka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yedayak @ishitasequeira