feat(ui): display sha's revision in every history release (#19962) #19963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
reggie-k
approved these changes
Sep 17, 2024
reggie-k
added
component:ui
gdsoumya
reviewed
Sep 18, 2024
There was a problem hiding this comment.
@Tchoupinax can you just add some screenshots of before and after?
|
Sure! Before: After: |
todaywasawesome
approved these changes
Sep 18, 2024
gdsoumya
approved these changes
Sep 19, 2024
7 tasks
|
Hello @reggie-k, Could this fix be part of Thanks! |
|
/cherry-pick release-2.13 |
1 similar comment
|
/cherry-pick release-2.13 |
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…9963) Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Following the regression reported by this issue, I made the fix to hide only the params table.
I created a sub component to have the state of the panel (open or closed) isolated for each history.
Closes #19962