Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diff): avoid cache miss in server-side diff (#20423) (cherry-pick #20424) #20450

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(diff): avoid cache miss in server-side diff (#20423) (#20424)

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

  • fix silly mistakes

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com


Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

* fix(diff): avoid cache miss in server-side diff (#20423)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix silly mistakes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner October 18, 2024 13:37
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.58%. Comparing base (85be9a4) to head (f489e12).
Report is 1 commits behind head on release-2.12.

Files with missing lines Patch % Lines
pkg/apis/application/v1alpha1/types.go 0.00% 6 Missing ⚠️
controller/state.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-2.12   #20450   +/-   ##
=============================================
  Coverage         49.58%   49.58%           
=============================================
  Files               313      313           
  Lines             52875    52887   +12     
=============================================
+ Hits              26216    26223    +7     
- Misses            24179    24183    +4     
- Partials           2480     2481    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 68f63e7 into release-2.12 Oct 18, 2024
22 of 24 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-3198ab-release-2.12 branch October 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant