-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): fix flaky e2e tests - ignore temporary files when checking for out of bound symlinks #20527
fix(ci): fix flaky e2e tests - ignore temporary files when checking for out of bound symlinks #20527
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: cef <moncef.abboud95@gmail.com>
12004bc
to
fc12992
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20527 +/- ##
==========================================
- Coverage 55.07% 55.05% -0.03%
==========================================
Files 322 322
Lines 54927 55026 +99
==========================================
+ Hits 30253 30295 +42
- Misses 22068 22131 +63
+ Partials 2606 2600 -6 ☔ View full report in Codecov by Sentry. |
Thank you @CefBoud . This flakiness appeared recently. Had you chance to check what change may introduced this issue? Just wonder why it started to happens |
@pasha-codefresh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems safe and reasonable. If a file doesn't exist, it can't provide a path for traversal.
/cherry-pick release-2.13 |
…ks (#20527) Signed-off-by: cef <moncef.abboud95@gmail.com>
…ks (argoproj#20527) Signed-off-by: cef <moncef.abboud95@gmail.com>
* fix: disable automaxprocs logging (#20069) * disable automaxprocs logging Signed-off-by: nitishfy <justnitish06@gmail.com> fix lint checks Signed-off-by: nitishfy <justnitish06@gmail.com> move maxprocs to main.go Signed-off-by: nitishfy <justnitish06@gmail.com> move set auto max procs to a function Signed-off-by: nitishfy <justnitish06@gmail.com> add info log Signed-off-by: nitishfy <justnitish06@gmail.com> * add info log Signed-off-by: nitishfy <justnitish06@gmail.com> * fix lint checks Signed-off-by: nitishfy <justnitish06@gmail.com> * fix lint checks Signed-off-by: nitishfy <justnitish06@gmail.com> * add unit test Signed-off-by: nitishfy <justnitish06@gmail.com> * fix lint issues Signed-off-by: nitishfy <justnitish06@gmail.com> --------- Signed-off-by: nitishfy <justnitish06@gmail.com> (cherry picked from commit cfa1c89) * fix(ci): ignore temporary files when checking for out of bound symlinks (#20527) Signed-off-by: cef <moncef.abboud95@gmail.com> --------- Signed-off-by: cef <moncef.abboud95@gmail.com> Co-authored-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: ABBOUD Moncef <moncef.abboud95@gmail.com>
…ks (argoproj#20527) Signed-off-by: cef <moncef.abboud95@gmail.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Addresses part of #11667
Description
This PR fixes errors that happen frequently in the CI 1, 2.
These issues arise when walking through a directory, where temporary files—like Git lock files—are scanned but may be deleted by the time their handlers execute.
Checklist: