Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only check for source position when --show-params is set (cherry-pick #20682) #20689

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: check for source position when --show-params is set (#20682)

Signed-off-by: Soumya Ghosh Dastidar gdsoumya@gmail.com

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner November 7, 2024 07:21
@gdsoumya gdsoumya merged commit 99aab9a into release-2.13 Nov 7, 2024
9 of 13 checks passed
@gdsoumya gdsoumya deleted the cherry-pick-587167-release-2.13 branch November 7, 2024 07:21
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.00%. Comparing base (347f221) to head (2d3bbf7).
Report is 1 commits behind head on release-2.13.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.13   #20689      +/-   ##
================================================
- Coverage         55.04%   55.00%   -0.05%     
================================================
  Files               320      320              
  Lines             54667    54668       +1     
================================================
- Hits              30091    30068      -23     
- Misses            22000    22027      +27     
+ Partials           2576     2573       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant