fix: API server should not attempt to read secrets in all namespaces #20950
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng apps Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
…rrole (argoproj#20162)" This reverts commit fad534b.
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
alexmt
changed the title
gdsoumya
reviewed
Nov 25, 2024
andrii-korotkov-verkada
approved these changes
Nov 25, 2024
|
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…20950) * fix: api server is trying to list cluster wide secrets while generating apps Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Revert "fix: Fix argocd appset generate failure due to missing clusterrole (#20162)" This reverts commit fad534b. --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
gdsoumya
pushed a commit
that referenced
this pull request
Nov 26, 2024
…20950) (#20960) * fix: api server is trying to list cluster wide secrets while generating apps * Revert "fix: Fix argocd appset generate failure due to missing clusterrole (#20162)" This reverts commit fad534b. --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…rgoproj#20950) * fix: api server is trying to list cluster wide secrets while generating apps Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Revert "fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162)" This reverts commit fad534b. --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #20161
The #20162 fixes the issue by giving cluster-level secret permissions, but only if Argo CD is installed in a cluster-level mode.
PR fixes the root cause of #20161: API server incorrectly attempting to read secrets from all namespaces. Also reverts #20162 since API server should not really have permissions to list everything in a whole cluster.