Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix select destination cluster type in create app (issue #20961) #20970

Conversation

lsq645599166
Copy link
Contributor

Fixes #20961

This PR fixes an issue when the cluster type selection cannot change to name in create app panel.

Result

Before

20241127-164302.mp4

After

20241127-164141.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@lsq645599166 lsq645599166 requested a review from a team as a code owner November 27, 2024 08:43
Copy link

bunnyshell bot commented Nov 27, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsq645599166 , do you mind resolving the conflicts?

Signed-off-by: henry.liu <henry.liu@daocloud.io>
@lsq645599166 lsq645599166 force-pushed the fix/create_app_destination_cluster_type branch from 6619cc0 to 98c02b1 Compare December 11, 2024 10:25
@lsq645599166
Copy link
Contributor Author

@lsq645599166 , do you mind resolving the conflicts?
Hi @ishitasequeira , thanks for you review. I have already resolved the conflicts by rebase

@ishitasequeira ishitasequeira enabled auto-merge (squash) December 11, 2024 10:27
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lsq645599166 !!

@ishitasequeira ishitasequeira merged commit a78b628 into argoproj:master Dec 11, 2024
22 checks passed
GuySaar8 pushed a commit to GuySaar8/argo-cd that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cluster name selection is not working in New Application. Only cluster URL is working for Destination section.
4 participants