Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect expr for server stats in Grafana dashboard.json #21098

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: incorrect expr for server stats in Grafana dashboard.json #21098

merged 2 commits into from
Dec 11, 2024

Conversation

minchao
Copy link
Contributor

@minchao minchao commented Dec 9, 2024 •
edited
Loading

These panels belong to Server Stats, not Repo Server Stats.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@minchao
fix: incorrect expr for server stats in Grafana dashboard.json
540f669 
Signed-off-by: Minchao <minchao.220@gmail.com>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 9, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@minchao minchao marked this pull request as ready for review December 9, 2024 09:09
@minchao minchao requested a review from a team as a code owner December 9, 2024 09:09
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.23%. Comparing base (6a3cdb6) to head (df65c48).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21098      +/-   ##
==========================================
+ Coverage   55.19%   55.23%   +0.03%     
==========================================
  Files         324      324              
  Lines       55603    55603              
==========================================
+ Hits        30691    30712      +21     
+ Misses      22293    22264      -29     
- Partials     2619     2627       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

todaywasawesome
todaywasawesome approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thanks!

@todaywasawesome todaywasawesome enabled auto-merge (squash) December 11, 2024 15:10
@todaywasawesome todaywasawesome merged commit 6897c2e into argoproj:master Dec 11, 2024
26 checks passed
@minchao minchao deleted the typo-in-dashboard branch December 12, 2024 00:05
GuySaar8 pushed a commit to GuySaar8/argo-cd that referenced this pull request Dec 12, 2024
@minchao @todaywasawesome @GuySaar8
fix: incorrect expr for server stats in Grafana dashboard.json (argop…
f1384a4 
…roj#21098)

Signed-off-by: Minchao <minchao.220@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minchao @todaywasawesome @pasha-codefresh