Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor typos in code examples #3622

Merged
merged 1 commit into from
May 20, 2020
Merged

docs: minor typos in code examples #3622

merged 1 commit into from
May 20, 2020

Conversation

andyfeller
Copy link
Contributor

@andyfeller andyfeller commented May 20, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@andyfeller andyfeller changed the title Fix minor typos in code examples fix: minor typos in code examples May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #3622 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
- Coverage   41.22%   41.09%   -0.14%     
==========================================
  Files         115      115              
  Lines       16470    16475       +5     
==========================================
- Hits         6790     6770      -20     
- Misses       8799     8824      +25     
  Partials      881      881              
Impacted Files Coverage Δ
server/server.go 53.82% <0.00%> (-1.65%) ⬇️
pkg/apis/application/v1alpha1/hack.go 0.00% <0.00%> (ø)
server/application/application.go 28.31% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313de86...2b1a79f. Read the comment docs.

@andyfeller
Copy link
Contributor Author

Fixes typos introduced in #3292

@jannfis jannfis self-requested a review May 20, 2020 16:36
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @andyfeller! Thanks a lot!

@jannfis jannfis changed the title fix: minor typos in code examples docs: minor typos in code examples May 20, 2020
@jannfis jannfis merged commit 7c831ad into argoproj:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants