Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ARGO_INGRESS_LINK_PROTO variable for Ingress links #8127

Closed
wants to merge 1 commit into from
Closed

Expose ARGO_INGRESS_LINK_PROTO variable for Ingress links #8127

wants to merge 1 commit into from

Conversation

brsolomon-deloitte
Copy link
Contributor

Closes #8021.

Expose ARGO_INGRESS_LINK_PROTO environment variable to explicitly
tell controller to generate links of a certain protocol for
Ingress resources.

Example:

ARGO_INGRESS_LINK_PROTO=https
ARGO_INGRESS_LINK_PROTO=http

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Closes #8021.

Expose ARGO_INGRESS_LINK_PROTO environment variable to explicitly
tell controller to generate links of a certain protocol for
Ingress resources.

Example:

    ARGO_INGRESS_LINK_PROTO=https
    ARGO_INGRESS_LINK_PROTO=http
@brsolomon-deloitte
Copy link
Contributor Author

Haven't written any Go in a year or so, please go easy on me 😉

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #8127 (b6dd3b9) into master (3fe924e) will increase coverage by 0.00%.
The diff coverage is 70.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8127   +/-   ##
=======================================
  Coverage   41.51%   41.52%           
=======================================
  Files         174      174           
  Lines       22712    22714    +2     
=======================================
+ Hits         9430     9432    +2     
  Misses      11941    11941           
  Partials     1341     1341           
Impacted Files Coverage Δ
controller/cache/info.go 66.07% <70.58%> (+0.30%) ⬆️
util/settings/settings.go 46.85% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe924e...b6dd3b9. Read the comment docs.

@jannfis
Copy link
Member

jannfis commented Jan 14, 2022

Please see my comments on #8021

@brsolomon-deloitte
Copy link
Contributor Author

Please see my comments on #8021

I'm tracking, please feel free to close this if an env var is deemed to be not the best option.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD UI Ingress go-to links use wrong URL scheme (HTTP)
2 participants