Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd HPAs should support user provided metrics #2152

Closed
zswanson opened this issue Jul 6, 2023 · 0 comments · Fixed by #2166
Closed

argocd HPAs should support user provided metrics #2152

zswanson opened this issue Jul 6, 2023 · 0 comments · Fixed by #2166
Labels
argo-cd enhancement New feature or request

Comments

@zswanson
Copy link
Contributor

zswanson commented Jul 6, 2023

Is your feature request related to a problem?

ArgoCD helm chart is "hard coded" to use only pod Resource metrics for CPU and memory based on usage vs Requests. Users may have other metrics such as custom prometheus metric aggregations, that they'd rather use. The helm templates for the HPA resources should support user customization of the metric types that are permitted by HPA v2

Related helm chart

argo-cd

Describe the solution you'd like

User supplied values templating of the HPA spec.metrics fields

Describe alternatives you've considered

Currently we are disabling the chart autoscaling parameters and then using the values.extraObjects to define our own HPAs. This works, but due to issues with 'helm templating within helm templating' its hard to make these fully interopt with the rest of the chart so its a very custom solution to each use case.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants